From nobody Tue Dec 27 19:15:36 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NhPWb1wNLz2l2L2; Tue, 27 Dec 2022 19:15:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NhPWb1MyCz4FNd; Tue, 27 Dec 2022 19:15:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672168555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CZq2oqWADmH3789A8eVzpkfnZ0kXXqaQ3ew452j+/Aw=; b=IDv/OEkGl3mUWLo64LbK/nYQAyk1VftDfyDVI9S0+OwVnkgdKgecSXVJv3ozvcrgghA2jk rR+LhvHR7ME9mq9Kz/pXK8LN9RLQ37/nW8kp+WCA0ELjBANmlNRIr42kESyS8huCDCzvLi 2ChDln6BDW9g2QgCtpPo4SC7TFEQHTo5OfRiVNGDQ5SxMF4JCsETHaM2Z4DjYLp7eEeUyv 9+r4UbUHmWs/phEf9m41LOvkg1jkap2X1uF9JmMXu3JT/pRVvVlg4TSBGAu9G7AhXUf3nO dLfxyR6Lsy2vmUd9K66mrQGAdeseGrPUQDk+bR59KIlCfWU1WO70FJpLWWC0Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672168555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CZq2oqWADmH3789A8eVzpkfnZ0kXXqaQ3ew452j+/Aw=; b=mCGCvSp0805BbDBYOpDgWC5zjgKgOUcAWePAHCVlRkFw/ZJaXEsgzcz6ODrgs94qKyli32 X/8WEvnuviRr2dJflsI6TEnPFOpC1MMslEjGZbJfeXNVttaUWaRMOslb2HzjwmAfP+J5/H cR3eEn/JaGLHMvC7oQYWGprfxys08pABAxSmKNEHetJQBoo/bxkcK3PiulgN6JZi3ztM5Q ji6rjPYlfguIyBTSo0QTV1fVRHOg4/boRXmjBggu/AJe5nK0X69rr3OzxbxgYEP6wV8GwI 9nOPD6v6ZICS+yXsnsesZa4LeEmCeYCAkuUIH/YTrdJPaIm0nEhDdfYf8lKcVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672168555; a=rsa-sha256; cv=none; b=to8FyvnGiPYnXzNp5081iDbrGsPHrR6i3tHim7BWgLqp1ITlw54Wbc5SgBUAZI8FeLfaUZ 5AYzX34uMh0abmZ3Ku3RY4tW/OjZnUCGSO+MKg9J8gLXI/Jdyfs9PN/ZD6PMvwOlB7tbyX kX3irzENN8s6JtJQT54CuCdHjMsBWuKE9j3I3PcqNtlQsMF6i9iJOmbxvtNTOaJeavqLad XUKweltn06+gTaTeQlCFdxpkmSK01scnGMP0I6rGXUZhzjdBrOT2gFfgLGeQ+MdP83C2eh M7WNpUzag/Rbh7vVIbKhJO30wSXL+ES/rifuV6dxHw0GurYTr6XBHwTQqqaaEQ== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NhPWZ6wd7z1JyX; Tue, 27 Dec 2022 19:15:54 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 7F56A198E9; Tue, 27 Dec 2022 20:15:52 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: git: 526f57bf85a2 - main - Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for clang 15. From: Dimitry Andric In-Reply-To: <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org> Date: Tue, 27 Dec 2022 20:15:36 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <5AA0B3E0-4F11-4F8C-8950-028A59BB2955@FreeBSD.org> References: <202212251159.2BPBxmAG029954@gitrepo.freebsd.org> <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3731.300.101.1.3) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 27 Dec 2022, at 18:40, John Baldwin wrote: >=20 > On 12/25/22 3:59 AM, Dimitry Andric wrote: >> The branch main has been updated by dim: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D526f57bf85a2b9b113c55ded47b932ab= c8567bc5 >> commit 526f57bf85a2b9b113c55ded47b932abc8567bc5 >> Author: Dimitry Andric >> AuthorDate: 2022-07-25 10:29:58 +0000 >> Commit: Dimitry Andric >> CommitDate: 2022-12-25 11:58:22 +0000 >> Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for = clang 15. >> MFC after: 3 days >> --- >> share/mk/bsd.sys.mk | 17 +++++++++++++++-- >> sys/conf/kern.mk | 4 ++++ >> 2 files changed, 19 insertions(+), 2 deletions(-) >> diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk >> index a220c9d173ed..43359fed29c7 100644 >> --- a/share/mk/bsd.sys.mk >> +++ b/share/mk/bsd.sys.mk >> @@ -86,6 +94,11 @@ CWARNFLAGS.clang+=3D -Wno-unused-const-variable >> .if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_VERSION} >=3D = 130000 >> CWARNFLAGS.clang+=3D -Wno-error=3Dunused-but-set-variable >> .endif >> +.if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_VERSION} >=3D = 150000 >> +CWARNFLAGS.clang+=3D -Wno-error=3Darray-parameter >=20 > I've fixed all these that GCC 12 finds. Do we really need to disable = it for clang > now after I've pushed those recent fixes? I didn't notice, but it's likely because I had the above in the llvm-15-update branch for months now. I found some old build logs from the beginning of December, and they still contained ~20 of these warnings. But if they're all fixed now then sure, lets's remove the -Wno-error=3D again. >> +CWARNFLAGS.clang+=3D -Wno-error=3Ddeprecated-non-prototype >=20 > I'm curious how many places are broken by this and how much it would = be to fix? > This is just adding '(void)' in place of '()', yes? 5859 instances, as of the last count. I committed a bunch of these, and then got some negative feedback about it, so I decided to simply make the warning non-fatal. Somebody else can go over these one by one and fix them as drive-by commits. Indeed the fix is just replacing () in declarations and definitions of C functions with (void). -Dimitry --Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY6tEWQAKCRCwXqMKLiCW owEXAKDZx2NV5xDi63O8xmMICDj3fAFJngCfRj1BWWx0a/Mf/HUj7fZFIrYMTCY= =Ef/H -----END PGP SIGNATURE----- --Apple-Mail=_AC5C7F6F-B79A-4C2C-BD28-CDD346408558--