From owner-svn-src-head@freebsd.org Thu Aug 27 16:04:45 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3343F9C39DF for ; Thu, 27 Aug 2015 16:04:45 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm43-vm4.bullet.mail.bf1.yahoo.com (nm43-vm4.bullet.mail.bf1.yahoo.com [216.109.114.223]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DBBDC9B for ; Thu, 27 Aug 2015 16:04:44 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1440691476; bh=1W5onbuGuQkeLsQWZ/NWzN5arfjOsgV6nPRahUfrMxU=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=ayowMrBUAbCi1B1Rio4iSIrtdAK3DD5cth4jL02sbLj8K2AeCZrID+fxAb/rxxsn3TLNNO4IHORCCZhcbs8lgIqBIRKMSB5/s235D836a6q5axQT+q7uOlZgEDq0pwgqhYrw2NFK+6TrqWIjgzZLASmBy3KxU0KMtTkbWgKebdI+QoU2c8bFq2dPJ9FwITUgL8jQ6AT1rTeuTy1Qybc4P9sA0HpFr76BlVyVCtiHsuEhwRdXvMfYrQlLRerbCilo+HHIR49xhkkoJb/5cUJXaKNWI3kXFbFwFkYs9JXNaVL+iRc7/3ttdoiidPcy6b4FiOSsd8uPcKVzzgq1/fBL1Q== Received: from [98.139.215.142] by nm43.bullet.mail.bf1.yahoo.com with NNFMP; 27 Aug 2015 16:04:36 -0000 Received: from [98.139.211.199] by tm13.bullet.mail.bf1.yahoo.com with NNFMP; 27 Aug 2015 16:04:36 -0000 Received: from [127.0.0.1] by smtp208.mail.bf1.yahoo.com with NNFMP; 27 Aug 2015 16:04:36 -0000 X-Yahoo-Newman-Id: 939715.79942.bm@smtp208.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Mr4muu4VM1nMsZb7M72j6MGA.Vs9ZSl6aQiMv0Ri5uY_XeC 7xJiyLqRPhAQBeg.9M0sihW1dWJSe84PqjyNy_UJ4Iz2aZsPdSyG5oraLQEm k7QHCJKWoT9tyjLZVx4acNr2JzDjRj7pDY2F9GbhCCOAjMFieIpO9XmqFTg. dM.wgHBWcRTNAN1odrRyXRGWyGFipIBIzZiqDJBhhc61H2AepFk1MWGd6BV8 FWw7RGaSF8xfGkrOBJEbWoO4iZDTHwr6WLYpEPfYJAkvJvh5hsYQ5vlsQLZP DtQm_hvPkY2MDN3.lkR84KYmsKqKTRh8toEYAkiMPL.zNEJBVCoOCqtbQRmO pXcgCtLF9_0qgrv8mUvKHO6k_xupuaChxE6gwViToG9Q7clRBCkeIlh_TGYB Iz.rGRAZTELQm7zbWrYjTrmcJVH6BP3mez0cyzx7EXUgceYB92HZyLv1NaAS tBpuFPEyfIu7_H6stwkTy3F6aJLvKQaHYamMWSEXY_HLdKLFC2wFrpRGOWMv oqpF8UlENtx5Luoqb.75eG956b1fzpdX8 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r287206 - head/sys/sys To: Alexander Kabaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201508271400.t7RE0Nbc071389@repo.freebsd.org> From: Pedro Giffuni Message-ID: <55DF3519.1000106@FreeBSD.org> Date: Thu, 27 Aug 2015 11:04:41 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <201508271400.t7RE0Nbc071389@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2015 16:04:45 -0000 Hello kan; On 08/27/15 09:00, Alexander Kabaev wrote: > Author: kan > Date: Thu Aug 27 14:00:23 2015 > New Revision: 287206 > URL: https://svnweb.freebsd.org/changeset/base/287206 > > Log: > Repair sys/cdefs.h enough to be usable with GCC 5.x > > The __alloc_size and __alloc_align need to be defined to > nothingness for lint, but the existing check is deficient > and allows attributes with working __has_attrubute() to > slip through. > AFAICT GCC hasn't added __has_attribute(), but if they did recently that is great news. > Modified: > head/sys/sys/cdefs.h > .. > #if !__GNUC_PREREQ__(2, 95) > @@ -371,24 +382,12 @@ > #define __returns_twice > #endif > > -#if __has_attribute(alloc_size) || __GNUC_PREREQ__(4, 3) > -#define __alloc_size(x) __attribute__((__alloc_size__(x))) > -#else > -#define __alloc_size(x) > -#endif > - This surely got through in GCC's case through the __GNUC_PREREQ__. Of course gcc 4.2 has neither attribute but clang has alloc_size so I wonder why it hasn't affected the lint builds. Just curiosity, the change is OK but it will be getting ugly if we have to add all the new attributes in the !lint section. Regards, Pedro.