From owner-cvs-src@FreeBSD.ORG Sat Aug 16 13:24:59 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5754B37B401; Sat, 16 Aug 2003 13:24:59 -0700 (PDT) Received: from cheer.mahoroba.org (flets19-233.kamome.or.jp [218.45.19.233]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1954643F3F; Sat, 16 Aug 2003 13:24:55 -0700 (PDT) (envelope-from ume@mahoroba.org) Received: from lyrics.mahoroba.org (IDENT:mGx/v5ZBT7XzQ3PJs2gY2O7s5286sCM1iWJY6U7gUuMwqP3eSKy3rGES3TRiovk/@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)h7GKOn6G034031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 17 Aug 2003 05:24:49 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sun, 17 Aug 2003 05:24:49 +0900 Message-ID: From: Hajimu UMEMOTO To: Pawel Jakub Dawidek In-Reply-To: <20030816195657.GV395@garage.freebsd.pl> References: <200308161900.h7GJ0W66093273@repoman.freebsd.org> <20030816195657.GV395@garage.freebsd.pl> User-Agent: xcite1.38> Wanderlust/2.11.3 (Wonderwall) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 5.1-CURRENT MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=-1.0 required=5.0 tests=IN_REP_TO,REFERENCES,USER_AGENT version=2.55 X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Hajimu UMEMOTO cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/rtsold if.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Aug 2003 20:25:00 -0000 Hi, >>>>> On Sat, 16 Aug 2003 21:56:57 +0200 >>>>> Pawel Jakub Dawidek said: nick> [1 ] nick> On Sat, Aug 16, 2003 at 12:00:32PM -0700, Hajimu UMEMOTO wrote: nick> [...] nick> +> - use strncpy just in case. nick> [...] nick> +> @@ -333,7 +333,7 @@ get_llflag(const char *name) nick> +> continue; nick> +> nick> +> memset(&ifr6, 0, sizeof(ifr6)); nick> +> - strcpy(ifr6.ifr_name, name); nick> +> + strncpy(ifr6.ifr_name, name, sizeof(ifr6.ifr_name)); nick> +> memcpy(&ifr6.ifr_ifru.ifru_addr, sin6, sin6->sin6_len); nick> +> if (ioctl(s, SIOCGIFAFLAG_IN6, &ifr6) < 0) { nick> +> warnmsg(LOG_ERR, __func__, nick> If so, this should be: nick> strncpy(ifr6.ifr_name, name, sizeof(ifr6.ifr_name) - 1); nick> or even better: nick> strlcpy(ifr6.ifr_name, name, sizeof(ifr6.ifr_name)); Yes, it should be so. I've just committed it and sent the patch to KAME. Thank you. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/