From owner-freebsd-current Fri Feb 22 20:38:12 2002 Delivered-To: freebsd-current@freebsd.org Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by hub.freebsd.org (Postfix) with ESMTP id 00DD637B405 for ; Fri, 22 Feb 2002 20:38:08 -0800 (PST) Received: (qmail 32203 invoked from network); 23 Feb 2002 04:38:07 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([65.91.137.227]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 23 Feb 2002 04:38:07 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Date: Fri, 22 Feb 2002 23:38:07 -0500 (EST) From: John Baldwin To: dillon@FreeBSD.org Subject: First (easy) td_ucred patch Cc: current@FreeBSD.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I'm currently testing the following patch whcih is a subset of the td_ucred changes. It involves no API changes, but only contains 2 basic changes: 1) We still need Giant when doing the crhold() to set td_ucred in cred_update_thread(). This is an old bug that is my fault. I knew that PROC_LOCK was sufficient yet which was my reason for not using td_ucred. However, we could still be derferencing a stale p_ucred and doing very bad things, so this needs to be fixed until p_ucred is fully protected by the PROC_LOCK. This also means that td_ucred is now safe to use. As such: 2) All the "easy" p->p_ucred -> td->td_ucred changes that don't involve the changes to API's such as suser() and p_canfoo(). The next patch in this series will most likely be the suser() API change. http://www.FreeBSD.org/~jhb/patches/ucred.patch -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message