Date: Sun, 1 Apr 2012 13:01:10 -0700 From: "Jason Helfman" <jhelfman@e-e.com> To: "Eitan Adler" <lists@eitanadler.com> Cc: FreeBSD Ports Mailing List <ports@freebsd.org>, Ruslan Mahmatkhanov <cvs-src@yandex.ru> Subject: Re: Preferred way of applying OSVERSION-dependend patches Message-ID: <3feda25fa085f9040079a33bc0f26ff9.squirrel@mail.experts-exchange.com> In-Reply-To: <CAF6rxg=BU4NzRrcAQGJfZTJXLN0550mgscPaFq1pq=FjSO6bkA@mail.gmail.com> References: <4F7827A7.3030804@yandex.ru> <CAF6rxg=BU4NzRrcAQGJfZTJXLN0550mgscPaFq1pq=FjSO6bkA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 1 April 2012 06:02, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
>>
>> Good day!
>>
>> What is a preferred way of doing subj?
>>
>> 1. Add an extra-patch-* to files/ subdirectory and apply it depending
>> of checks in Makefile (.if ${OSVERSION}).
>> 2. Add an patch-* to files subdirectory that applies unconditionally
>> and that checking for __FreeBSD_version in app code itself.
>>
>> The second one will guarantee that the patch still applies cleanly on
>> port
>> versions update, but it will make it more hard to find conditional
>> checks
>> for obsoleted FreeBSD versions (because most people, I believe, only
>> looking
>> to Makefile for things like this).
>
> #1 for exactly the reason you specify: it makes it easier to figure
> out why something is being patched and when that patch is no longer
> required.
>
I say #3 :)
So if it is non-conditional in the port, but you choose to make it
conditional in the code -- Send the patch upstream, or to maintainer of
code, so the patch isn't necessary in the portstree.
-jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3feda25fa085f9040079a33bc0f26ff9.squirrel>