From owner-freebsd-ports@FreeBSD.ORG Sat Jan 24 02:06:21 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D185216A4CE for ; Sat, 24 Jan 2004 02:06:21 -0800 (PST) Received: from smtp.infracaninophile.co.uk (smtp.infracaninophile.co.uk [81.2.69.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BBE243D31 for ; Sat, 24 Jan 2004 02:06:19 -0800 (PST) (envelope-from m.seaman@infracaninophile.co.uk) Received: from happy-idiot-talk.infracaninophile.co.uk (localhost [IPv6:::1]) i0OA6Ese067336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 24 Jan 2004 10:06:14 GMT (envelope-from matthew@happy-idiot-talk.infracaninophile.co.uk) Received: (from matthew@localhost)id i0OA6Bbt067331; Sat, 24 Jan 2004 10:06:11 GMT (envelope-from matthew) Date: Sat, 24 Jan 2004 10:06:11 +0000 From: Matthew Seaman To: Sepherosa Ziehau Message-ID: <20040124100611.GA66769@happy-idiot-talk.infracaninophile.co.uk> References: <20040123123924.GA49081@happy-idiot-talk.infracaninophile.co.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1i X-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=2.62 X-Spam-Checker-Version: SpamAssassin 2.62 (2004-01-11) on happy-idiot-talk.infracaninophile.co.uk cc: "ports@FreeBSD.org" Subject: Re: FreeBSD Port: jfreechart-0.9.13 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2004 10:06:22 -0000 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 24, 2004 at 08:29:42AM +0800, Sepherosa Ziehau wrote: > On Fri, 23 Jan 2004 12:39:24 +0000, Matthew Seaman=20 > wrote: > >On Fri, Jan 23, 2004 at 07:28:08PM +0800, Sepherosa Ziehau wrote: > >>without a java document, a java library is useless. I have upgraded > >>jfreechart to 0.9.16 and add javadoc support. > >>Hope somebody can review it and commit it for me. > >Nice work. However, I can see a couple of problems with your patch. [..deletia...] > Thank you for your advice, and the nice mysql-connector. > I regenerated the patch according to your advice. > Please review it. Looks good. However, PORTDOCS and installing port ducmentation should be conditional on NOPORTDOCS not being defined. Can you submit these changes via send-pr, which is the official channel for getting such things committed? You might want to consider taking over maintainership for this port. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. 26 The Paddocks Savill Way PGP: http://www.infracaninophile.co.uk/pgpkey Marlow Tel: +44 1628 476614 Bucks., SL7 1TH UK --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAEkOTdtESqEQa7a0RAn+vAJ9tfJE4UBCEaiu7/Zc/9AWllRoy+QCeM9cb mQ0uAGqRwZwR6m6Q5Od1fvE= =/vlm -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--