From owner-svn-src-all@FreeBSD.ORG  Thu Nov 12 01:22:05 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A1F6C106566B;
	Thu, 12 Nov 2009 01:22:05 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-fx0-f227.google.com (mail-fx0-f227.google.com
	[209.85.220.227])
	by mx1.freebsd.org (Postfix) with ESMTP id E03EB8FC12;
	Thu, 12 Nov 2009 01:22:04 +0000 (UTC)
Received: by fxm27 with SMTP id 27so1801266fxm.3
	for <multiple recipients>; Wed, 11 Nov 2009 17:22:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:received:in-reply-to
	:references:date:x-google-sender-auth:message-id:subject:from:to
	:content-type; bh=r3SwY+1qetzwIhDEzZg36bCh7Z2/iP1SHpzCjnM+SlQ=;
	b=Cdj5VMrrIrSPqjX9NnD0e19r6C/FN1F6xrTW+UbJZs26a8b/lmGPyXUlCSm7ax1FXK
	SOBmeexoWpr29j2zJSXxwVQPvQf5BY8lrSIKtnXX5RU1NR9yWuiivzuae5JEIIxw42Rt
	oDtPCSdPLH1VI9upfVLMn0YgcznMW9+yiNZeA=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:content-type;
	b=nxoPZUO0bLZLYdrlvkuhJvxmxim2jN2OKwP7ScPdqo0HYguyDm4Fom/JLRWfAFy7KJ
	14LkesYmBPirRCZbRcpYgYK9QfF2CTHjxJ39bWA7uhwD4ZO6Ch7itYU3OdDpnPwoJOAJ
	LZ3ulP2tobNIwDb2mtyGPjX5WSZXq+VSKI8K4=
MIME-Version: 1.0
Sender: asmrookie@gmail.com
Received: by 10.223.2.69 with SMTP id 5mr319003fai.88.1257988923676; Wed, 11 
	Nov 2009 17:22:03 -0800 (PST)
In-Reply-To: <200911120052.nAC0qEjC012881@svn.freebsd.org>
References: <200911120052.nAC0qEjC012881@svn.freebsd.org>
Date: Thu, 12 Nov 2009 02:22:03 +0100
X-Google-Sender-Auth: 55a5a7d14c6603f1
Message-ID: <3bbf2fe10911111722j436d8b82oa66fb5cb581c7205@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org, 
	svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
Cc: 
Subject: Re: svn commit: r199209 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Nov 2009 01:22:05 -0000

2009/11/12 Attilio Rao <attilio@freebsd.org>:
> Author: attilio
> Date: Thu Nov 12 00:52:14 2009
> New Revision: 199209
> URL: http://svn.freebsd.org/changeset/base/199209
>
> Log:
>  The building the dev nameunit string, in devclass_add_device() is based
>  on the assumption that the unit linked with the device is invariant but
>  that can change when calling devclass_alloc_unit() (because -1 is passed
>  or, more simply, because the unit choosen is beyond the table limits).
>  This results in a completely bogus string building.
>
>  Fix this by reserving the necessary room for all the possible characters
>  printable by a positive integer (we do not allow for negative unit
>  number).
>
>  Reported by:  Sandvine Incorporated
>  Reviewed by:  emaste

Sorry, forgot to add:
reviewed by: jhb, imp

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein