From owner-svn-src-head@FreeBSD.ORG Thu Apr 1 21:23:54 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D80851065673; Thu, 1 Apr 2010 21:23:54 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (unknown [IPv6:2001:470:1f09:679::1]) by mx1.freebsd.org (Postfix) with ESMTP id 9CA198FC0A; Thu, 1 Apr 2010 21:23:54 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id D71EB93B1; Thu, 1 Apr 2010 21:23:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on muon.cran.org.uk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=8.0 tests=AWL,BAYES_00,RDNS_DYNAMIC autolearn=no version=3.2.5 Received: from core.draftnet (87-194-158-129.bethere.co.uk [87.194.158.129]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA; Thu, 1 Apr 2010 21:23:53 +0000 (UTC) From: Bruce Cran To: Alexander Motin Date: Thu, 1 Apr 2010 22:23:49 +0100 User-Agent: KMail/1.13.1 (FreeBSD/9.0-CURRENT; KDE/4.4.1; amd64; ; ) References: <201003131117.o2DBHek2003410@svn.freebsd.org> <4BB2182C.4080203@FreeBSD.org> In-Reply-To: <4BB2182C.4080203@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201004012223.49249.bruce@cran.org.uk> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Cran Subject: Re: svn commit: r205119 - head/contrib/top X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 21:23:55 -0000 On Tuesday 30 March 2010 16:26:36 Alexander Motin wrote: > Bruce Cran wrote: > > Author: brucec > > Date: Sat Mar 13 11:17:39 2010 > > New Revision: 205119 > > URL: http://svn.freebsd.org/changeset/base/205119 > > > > Log: > > Change the 'amt' parameter in format_k2 from int to unsigned long long > > to match the values passed in and prevent the SIZE field being > > corrupted when more than 2TB is allocated. > > This change seems broke top on ARM, as declaration in util.h doesn't > specifies argument type, and caller assumes int there. To make it work > correctly, second part should be done: > > --- top.prev/utils.h 2009-10-14 15:23:42.000000000 +0300 > +++ top/utils.h 2010-03-30 18:14:11.000000000 +0300 > @@ -21,4 +21,4 @@ long percentages(); > char *errmsg(); > char *format_time(); > char *format_k(); > -char *format_k2(); > +char *format_k2(unsigned long long); Sorry, I thought things would just work since format_k2 is only ever being called with a 64-bit argument. I've committed the patch in r206056. -- Bruce Cran