From owner-svn-src-head@FreeBSD.ORG Sat Apr 10 06:26:37 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 22D0D1065748 for ; Sat, 10 Apr 2010 06:26:37 +0000 (UTC) (envelope-from moonlightakkiy@yahoo.ca) Received: from web51806.mail.re2.yahoo.com (web51806.mail.re2.yahoo.com [206.190.38.237]) by mx1.freebsd.org (Postfix) with SMTP id B62178FC13 for ; Sat, 10 Apr 2010 06:26:36 +0000 (UTC) Received: (qmail 44884 invoked by uid 60001); 10 Apr 2010 06:26:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.ca; s=s1024; t=1270880796; bh=RfIFvTAQYnfCE+QVKLRSSxwYHbvsd5WRreN53aSGU5k=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=XbVm7CjQ09mofd7RIzWe6rgH1aB/t/mhuKh+b81SEwPo+oNbqEdKIBD2mhvlDmKrXC7SbE/vKjS69ifoMSqwWsmSZPrl+eKzzrno2FYoDba8B5FN3npg7IvEGTNrR8dbx+i30PajL19fhV8Ai5GwKKGnoABCmKNnI21MPBrRnSg= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.ca; h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=u+GUMafKpJrE/D311xCPVt4fzmLDXrJ96zJDC/pjaAHytYQGhKzo+FMbcodVzGPUkRFv+6MTOWi/dWwzPYS7wSU0wjuLcdqgopifFFWCbIhid73f9a3I+Ij1pBMr/ow7gEaKG3uPu4gv5dFSztdBjaPJfPh2JPI0pAz1rYwRy+M=; Message-ID: <193853.44645.qm@web51806.mail.re2.yahoo.com> X-YMail-OSG: aKC4__sVM1l639zK9QdrWOhoS31GdDANEgxFK9Z_7pFCthP23s263b8GCCntg3C8pf8pkNMqMu7yTCatHxzqT_bJ8gLwvIckGd0qVlWHTMZtkyMRjq_27Z3ucBEMohzlAOLQYRV00dhntinP785ZvO52gJrBaZactGsRBUjzn9B1ThWduvGIoIVBlN.TeFJ_nq23CUfVH454LyD8V2w2zuyW0p1M0ypoTwvU2JjoIawI0sZJKjlzQhq9WLAlh_Yfbku_IvSZnxRGjCcvg2K20BvNjuOSu1o0tzQDFx.1uzaQ9UVqjVEL4Z_gJ0NiopyVYPv0Kq5DgSjnz3nNZeU45g-- Received: from [173.183.132.20] by web51806.mail.re2.yahoo.com via HTTP; Fri, 09 Apr 2010 23:26:35 PDT X-Mailer: YahooMailRC/348.3 YahooMailWebService/0.8.100.260964 References: <20100407165048.8CF9E106566B@hub.freebsd.org> <488108.55494.qm@web51803.mail.re2.yahoo.com> <81BE57A1-3E1E-4BB9-9FCE-080B34B4452C@FreeBSD.org> Date: Fri, 9 Apr 2010 23:26:35 -0700 (PDT) From: PseudoCylon To: Rui Paulo In-Reply-To: <81BE57A1-3E1E-4BB9-9FCE-080B34B4452C@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r206358 (patch for if_run) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2010 06:26:37 -0000 >>>> Author: rpaulo >>>> Date: Wed Apr 7 15:29:13 2010 >>>> New Revision: 206358 >>>> URL: http://svn.freebsd.org/changeset/base/206358 >>>> >>>> Log: >>>> net80211 rate control framework (net80211 ratectl). >>>> >>>> This framework allows drivers to abstract the rate control algorithm and >>>> just feed the framework with the usable parameters. The rate control >>>> framework will now deal with passing the parameters to the selected >>>> algorithm. Right now we have AMRR (the default) and RSSADAPT but there's >>>> no way to select one with ifconfig, yet. >>>> The objective is to have more rate control algorithms in the net80211 >>>> stack so all drivers[0] can use it. Ideally, we'll have the well-known >>>> sample rate control algorithm in the net80211 at some point so all >>>> drivers can use it (not just ath). >>>> >>> >>> Hello, >>> >>> I've just tried the commit and run(4) works fine out of the box. It properly updates the rate. >>> >>> Thank you for updating the driver. >>> >>> AK >>> >> >> Sorry, correction. >> >> I've got complain from witness >> >> uma_zalloc_arg: zone "64" with the following non-sleepable locks held: >> exclusive sleep mutex run0 (network driver) r = 0 (0xffffff80008de128) locked @ /usr/src>/sys/dev/usb/usb_request.c:540 >> KDB: stack backtrace: >> db_trace_self_wrapper() at db_trace_self_wrapper+0x2a >> _witness_debugger() at _witness_debugger+0x2e >> witness_warn() at witness_warn+0x2c2 >> uma_zalloc_arg() at uma_zalloc_arg+0x335 >> malloc() at malloc+0x9a >> amrr_node_init() at amrr_node_init+0x38 >> run_newstate() at run_newstate+0x363 >> ieee80211_newstate_cb() at ieee80211_newstate_cb+0xac >> taskqueue_run() at taskqueue_run+0x91 >> taskqueue_thread_loop() at taskqueue_thread_loop+0x3f >> fork_exit() at fork_exit+0x12a >> fork_trampoline() at fork_trampoline+0xe >> --- trap 0, rip = 0, rsp = 0xffffff803e5d0d30, rbp = 0 --- >> >> Just unlocking the mutex before calling ieee80211_ratectl_node_init() fix this. As long as >ieee80211_ratectl_node_init() won't be called with the same ni at the same time, unlocking should be safe. >> >> Here is patch > > >Can you try updating and see if everything works for you? Thanks. > >Regards, >-- >Rui Paulo Yes, everything is working. No debug/warning message. Thank you very much. AK __________________________________________________________________ Looking for the perfect gift? Give the gift of Flickr! http://www.flickr.com/gift/