From owner-freebsd-office@freebsd.org Mon Feb 18 18:14:56 2019 Return-Path: Delivered-To: freebsd-office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3D5E14E6AE0 for ; Mon, 18 Feb 2019 18:14:56 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 706C375EA8; Mon, 18 Feb 2019 18:14:55 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yw1-f67.google.com with SMTP id u200so6769848ywu.10; Mon, 18 Feb 2019 10:14:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LxVsVHkN4kQdrbqG0fLYvW4HkJYaHmuz0VlfRSrZs/M=; b=c6ZoSeqJ5soy8EYlzlkgdLZWwpGOEDVigEmNHBKJKx0sAslVjGDymmXlt5Dji/iBXi IopYGWRiO+qxjEQk/mOPrVqDWluaMgNgLsQ0MCL0Tr+QPLN+ccNFAGMNx7XZ4QEXxAJ1 8pEMY/CYbWu5AUAiF+jOdT3Ls6rYukj9ETlKquy+JntKgqSvVAP01nLD5O+jDLTI2pMC NY/Tyv/IuZ3Il7MazIlfZ3OZtaVRX6i5SaP3cq6pAZEeYif6BfG1RPqmYJNGwlNDhI+4 1QFDfTyhJr2gqzJc/H/2/yKM5i8af6EV918FxRirbH2PaCmQJAdiJYhkKbiaKgv1rDX6 Ciow== X-Gm-Message-State: AHQUAuY+d3/q+yIeUc7EtKlOOegUywnREw3Cx7+npgJv5koEIUlDDITs ADnIBieOdaytaTysdc22rGVB3FAIfApLndiq0vQ= X-Google-Smtp-Source: AHgI3IZ6Cs0eJ09bJrk7OQsozFSsgFacMpWqR87fF0ApwvOuuEYNHE1JNmQGNNqST29eYgwNkWUD230+RXSWZDtyMiA= X-Received: by 2002:a81:53c2:: with SMTP id h185mr20086501ywb.266.1550512227762; Mon, 18 Feb 2019 09:50:27 -0800 (PST) MIME-Version: 1.0 References: <20190218144218.GA98237@aurora.gregv.net> <20190218150917.GB98237@aurora.gregv.net> In-Reply-To: <20190218150917.GB98237@aurora.gregv.net> From: Li-Wen Hsu Date: Tue, 19 Feb 2019 02:50:15 +0900 Message-ID: Subject: Re: [call for help] libreoffice 6.2 update To: Greg Veldman Cc: freebsd-office@freebsd.org, Greg V , Greg Veldman , Jung-uk Kim , Justin Hibbits Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 706C375EA8 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.161.67 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-3.67 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RWL_MAILSPIKE_GOOD(0.00)[67.161.85.209.rep.mailspike.net : 127.0.0.18]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.49)[-0.495,0]; RCVD_IN_DNSWL_NONE(0.00)[67.161.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.17)[ipnet: 209.85.128.0/17(-3.79), asn: 15169(-1.98), country: US(-0.07)]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2019 18:14:56 -0000 On Tue, Feb 19, 2019 at 12:09 AM Greg Veldman wrote: > > On Mon, Feb 18, 2019 at 09:42:18AM -0500, Greg Veldman wrote: > > On Tue, Feb 05, 2019 at 11:12:25AM +0800, Li-Wen Hsu wrote: > > > Again, LibreOffice 6.2 will be announced soon. I squeezed few hours > > > to get most the patches updated > > > ( patch-bridges_source_cpp__uno_gcc3__linux__intel_share.hxx > > > and patch-bridges_source_cpp__uno_gcc3__linux__intel_uno2cpp.cxx > > > still need more work) > > > in my working repository: https://github.com/lwhsu/freebsd-ports-libreoffice > > > > I took a look at this, and now have all patches applying cleanly. > > However it appears some of these patches (or parts thereof) may > > actually no longer be needed, as upstream changed the arguments > > to some of the functions. I'm trying to read/understand the > > back story on some of these patches from the various commit logs > > to be sure if it's safe to change them.. > > OK, so that was actually a lot easier than I thought. Looks > like the two patches in question were introduced in r395799 > to make LibreOffice build on systems with pre-C++-11 compilers > (specifically, FreeBSD 9.x). As 9.x hasn't been officially > supported in over two years and the base C++ on 11.2 uses > C++-14, can I suggest that we just drop these patches rather > than trying to carry them forward every time LibreOffice gets > updated? Thanks very much for the help! Dropping these patches and focusing on the supported FreeBSD versions sounds very reasonable to me. Li-Wen