From owner-freebsd-current@FreeBSD.ORG Thu Oct 11 18:42:31 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEA0B16A420; Thu, 11 Oct 2007 18:42:31 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.freebsd.org (Postfix) with ESMTP id 92CAB13C469; Thu, 11 Oct 2007 18:42:31 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.1/8.14.1) with ESMTP id l9BIcCuV024963; Thu, 11 Oct 2007 11:38:12 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.1/8.14.1/Submit) id l9BIcCET024962; Thu, 11 Oct 2007 11:38:12 -0700 (PDT) (envelope-from sgk) Date: Thu, 11 Oct 2007 11:38:12 -0700 From: Steve Kargl To: Daniel Eischen Message-ID: <20071011183812.GA24863@troutmask.apl.washington.edu> References: <20071011180815.GA23643@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org, bde@freebsd.org Subject: Re: Removing a symbol from Symbol.map? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2007 18:42:31 -0000 On Thu, Oct 11, 2007 at 02:34:35PM -0400, Daniel Eischen wrote: > On Thu, 11 Oct 2007, Steve Kargl wrote: > > >In my journey through the libm source code, I've discovered > >that msun/src/w_cabs.c contains a function named z_abs. This > >symbol appears in libm's Symbol.map, but z_abs has not prototype > >in any header file under /usr/include. Thus, it is namespace > >pollution that I'd like to remove. Do I simply remove z_abs from > >Symbol.map or is there more to it then this? > > Nope, no more to it than just removing it from the symbol > map. I certainly don't have any object to removing symbols > that don't belong there. It should be MFC'd to -7 before > release if it really shouldn't be there. If it doesn't > make it to -7, then we'll need to keep it as a compatibility > function forever. > > >PS: Yes, I know bde will probably object to removal of z_abs > >because of compatibility issues with fdlibm and the other *BSD. > I certainly believe that z_abs should be removed. I've cc'd bde to see if he has an objection. -- Steve