From owner-cvs-src@FreeBSD.ORG Fri Oct 31 08:38:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3866616A4CE; Fri, 31 Oct 2003 08:38:27 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB3FE43F75; Fri, 31 Oct 2003 08:37:30 -0800 (PST) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h9VGbLWL031079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 31 Oct 2003 18:37:22 +0200 (EET) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9p2/8.12.9/Submit) id h9VGbEQV031068; Fri, 31 Oct 2003 18:37:14 +0200 (EET) (envelope-from ru) Date: Fri, 31 Oct 2003 18:37:14 +0200 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20031031163713.GA30874@sunbay.com> References: <200310310542.h9V5gr8v023991@repoman.freebsd.org> <20031031230028.K1418@gamplex.bde.org> <20031031123129.GB777@sunbay.com> <20031101002134.Y1748@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <20031101002134.Y1748@gamplex.bde.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Peter Wemm Subject: Re: cvs commit: src/sys/sys cdefs.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Oct 2003 16:38:27 -0000 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 01, 2003 at 12:34:51AM +1100, Bruce Evans wrote: > On Fri, 31 Oct 2003, Ruslan Ermilov wrote: >=20 > > On Fri, Oct 31, 2003 at 11:15:40PM +1100, Bruce Evans wrote: > > > ... > > > While it is good to check for warnings in system headers, this should= n't > > > be forced on everyone. Applications that want to check for the non-e= rror > > > of using undefined identifiers in cpp expressions shouldn't enable > > > warnings in system headers unless they want to get warnings if the he= aders > > > use this standard C feature (and other warnings). Applications in th= e src > > > tree won't do this. > > > > > What's the underlying issue here? I always thought that FreeBSD is dif= ferent > > from GNU is this respect -- we treat our system as the whole, so the pi= ece > > of code is as clean as its worst part; that may be a system header, too. > > Remember the issue? Old versions of buildworld used -nostdinc hack and > > -I... to ${WORLDTMP}/usr/include, and it caused WARNS to be generating > > different warnings while in buildworld compared to a normal (no -nostdi= nc) > > build. I'm against reverting the toplev.c change, but it also made the > > sys.mk part redundant, so the latter may be reverted now. >=20 > The system shouldn't have to satisfy cleanness standards of applications > that are not maintained by FreeBSD, especially when those standards > are bogus (e.g., compiling cleanly with -Wundef). Hopefull all the > important corner cases in the system headers are tested by buildworld > so that we don't need to enlist the application maintainers to find bugs > in system headers. >=20 Now that buildworld and normal builds behave the same, I tend to agree. Count this as "no objection" to revert this. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQE/oo+5Ukv4P6juNwoRAmJvAJ9Gt4svabjgqY37Y0BQRuDYsYA9rwCfc0Rj VKsKN9UNp8c2C0+8EgOddnQ= =r+if -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--