From owner-cvs-all Thu Jan 4 17: 8: 1 2001 From owner-cvs-all@FreeBSD.ORG Thu Jan 4 17:07:57 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from tele-post-20.mail.demon.net (tele-post-20.mail.demon.net [194.217.242.20]) by hub.freebsd.org (Postfix) with ESMTP id 3D75C37B400; Thu, 4 Jan 2001 17:07:56 -0800 (PST) Received: from calcaphon.demon.co.uk ([193.237.19.5]) by tele-post-20.mail.demon.net with esmtp (Exim 2.12 #2) id 14ELMI-000Mck-0K; Fri, 5 Jan 2001 01:07:55 +0000 Received: from localhost (localhost [127.0.0.1]) by calcaphon.demon.co.uk (8.11.1/8.9.1) with ESMTP id f0517Hq77116; Fri, 5 Jan 2001 01:07:22 GMT (envelope-from n_hibma@qubesoft.com) Date: Fri, 5 Jan 2001 01:07:17 +0000 (GMT) From: Nick Hibma X-Sender: n_hibma@bluebottle Reply-To: Nick Hibma To: Peter Wemm Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern makedevops.pl makeobjops.pl In-Reply-To: <200101041808.f04I8Jq10348@mobile.wemm.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Ok, I will separate them next time. Nick On Thu, 4 Jan 2001, Peter Wemm wrote: > Nick Hibma wrote: > > n_hibma 2001/01/04 05:41:24 PST > > > > Modified files: > > sys/kern makedevops.pl makeobjops.pl > > Log: > > Fix a bug in both scripts: HEADER sections were not emitted to the header > > file. > > > > While there fix the layout of function headers (noticable in long headers) > > > > Fix up some style nits. It's Perl and should be written in that style. > > > > Revision Changes Path > > 1.14 +9 -10 src/sys/kern/makedevops.pl > > 1.2 +319 -326 src/sys/kern/makeobjops.pl > > It is a bug to commit functional changes and reformatting changes in the > same commit. Like this, it is practically impossible to see the bug fix you > made as it is buried in the noise of the reformatting change. > > (I dont mean to pick on you specifically, others have been doing this > recently too) > > Cheers, > -Peter > -- > Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au > "All of this is for nothing if we don't go to the stars" - JMS/B5 > > > -- Work: n_hibma@qubesoft.com Personal: n_hibma@webweaving.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message