Date: Sun, 14 Jan 2018 07:22:28 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ben Woods <woodsb02@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r458949 - in head: devel/gvfs graphics/camera graphics/camerakit graphics/darktable graphics/digikam-kde4 graphics/entangle graphics/eos-movrec graphics/flphoto graphics/fusefs-gphotofs... Message-ID: <20180114072228.GA70693@FreeBSD.org> In-Reply-To: <201801140123.w0E1NFK8056770@repo.freebsd.org> References: <201801140123.w0E1NFK8056770@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 14, 2018 at 01:23:15AM +0000, Ben Woods wrote: > New Revision: 458949 > URL: https://svnweb.freebsd.org/changeset/ports/458949 > > Log: > graphics/libgphoto2: Update to 2.5.16 > graphics/gphoto2: Update to 2.5.15 > graphics/py-gphoto2: Update to 1.8.2 > > Modified: head/graphics/gphoto2/Makefile > ... > -USES= gmake jpeg pkgconfig tar:bzip2 > +USES= gmake jpeg localbase pkgconfig tar:bzip2 > GNU_CONFIGURE= yes > CONFIGURE_ENV= POPT_CFLAGS="$$(pkg-config --cflags popt)" \ > POPT_LIBS="$$(pkg-config --libs popt)" > @@ -30,8 +31,6 @@ AALIB_LIB_DEPENDS= libaa.so:graphics/aalib > AALIB_CONFIGURE_WITH= aalib > NLS_USES= gettext > NLS_CONFIGURE_ENABLE= nls > -NLS_CPPFLAGS= -I${LOCALBASE}/include > -NLS_LDFLAGS= -L${LOCALBASE}/lib I don't understand this part: should't it be NLS_USES=localbase instead? > Modified: head/graphics/libgphoto2/Makefile > ... > -USES= gmake iconv libtool pkgconfig tar:bzip2 > +USES= gmake iconv libtool localbase pkgconfig tar:bzip2 > USE_CSTD= gnu89 > GNU_CONFIGURE= yes > CONFIGURE_ENV= LTDLINCL="-I${LOCALBASE}/include" \ > @@ -24,9 +25,6 @@ CONFIGURE_ENV= LTDLINCL="-I${LOCALBASE}/include" \ > udevscriptdir=${WRKDIR} > INSTALL_TARGET= install-strip > USE_LDCONFIG= yes > - > -CPPFLAGS+= -I${LOCALBASE}/include > -LDFLAGS+= -L${LOCALBASE}/lib OK, here it's obvious, but the above change is not identical and thus deserves an explanation. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180114072228.GA70693>