From owner-freebsd-arch@FreeBSD.ORG Tue Apr 26 01:59:08 2011 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91B901065673 for ; Tue, 26 Apr 2011 01:59:08 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) by mx1.freebsd.org (Postfix) with ESMTP id 66E898FC1F for ; Tue, 26 Apr 2011 01:59:08 +0000 (UTC) Received: from cpe-74-66-24-70.nyc.res.rr.com ([74.66.24.70] helo=[192.168.1.119]) by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1QEXYR-00047K-OQ for arch@freebsd.org; Mon, 25 Apr 2011 21:59:07 -0400 From: George Neville-Neil Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Date: Mon, 25 Apr 2011 21:59:06 -0400 Message-Id: <7DC6C171-3802-4B5D-B2D8-2191C6FF6DBA@neville-neil.com> To: arch@freebsd.org Mime-Version: 1.0 (Apple Message framework v1084) X-Pgp-Agent: GPGMail 1.3.3 X-Mailer: Apple Mail (2.1084) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com Cc: Subject: Is there any reason not to remove all the spl() calls in rtsock.c? X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2011 01:59:08 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Howdy, I was just reviewing the code in rtsock.c, specifically rts_attach(). = Is there any reason not to just remove the spl* calls? I don't see anything obvious that = needs protection that is not now protected by a finer grained lock. Best, George -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) iEYEARECAAYFAk22JuoACgkQYdh2wUQKM9KWJgCglcc31hS2sQrzlrJTcZRK1zCc Y0gAnjNcE4AdBpOeh7oQGtD2nUTXr6tx =3Dzx2e -----END PGP SIGNATURE-----