From owner-p4-projects@FreeBSD.ORG  Fri Jan  9 03:20:31 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EE6031065673; Fri,  9 Jan 2009 03:20:30 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AC824106566B;
	Fri,  9 Jan 2009 03:20:30 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B7378FC12;
	Fri,  9 Jan 2009 03:20:30 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n093HldR086215;
	Thu, 8 Jan 2009 20:17:47 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Thu, 08 Jan 2009 20:18:02 -0700 (MST)
Message-Id: <20090108.201802.-1782466862.imp@bsdimp.com>
To: hselasky@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200901081839.27124.hselasky@freebsd.org>
References: <200901071009.n07A9jrs056953@repoman.freebsd.org>
	<20090108.102311.1541746851.imp@bsdimp.com>
	<200901081839.27124.hselasky@freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 155748 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jan 2009 03:20:32 -0000

In message: <200901081839.27124.hselasky@freebsd.org>
            Hans Petter Selasky <hselasky@freebsd.org> writes:
: On Thursday 08 January 2009, M. Warner Losh wrote:
: > In message: <200901071009.n07A9jrs056953@repoman.freebsd.org>
: >
: >             Hans Petter Selasky <hselasky@freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=155748
: > :
: > : Change 155748 by hselasky@hselasky_laptop001 on 2009/01/07 10:09:35
: > :
: > :
: > : 	Umass module quirk from Alexander Best
: > : 	to support Meizu Electronics MiniPlayer.
: > :
: > : Affected files ...
: > :
: > : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit
: > :
: > : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21
: > : (text+ko) ==== ====
: > : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21
: > : (text+ko) ====
: >
: > Why are these generated files committed to the tree?  We did a lot of
: > work to make usbdevs generated files not need to be committed to the
: > tree and this breaks that...
: >
: > Warner
: 
: Because they are not automatically generated any more.

They are automatically generated.

You mean that they are no longer automatically generated as part of
the build?  I'm wondering why not?  We went to a lot of trouble to dig
out of the problems that causes, and I'd hate to see us go back to the
bad old days...

Warner