From owner-freebsd-bugs@FreeBSD.ORG Fri Nov 28 11:20:18 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 243D616A4CE for ; Fri, 28 Nov 2003 11:20:18 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 876AD43FB1 for ; Fri, 28 Nov 2003 11:20:13 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hASJKDFY098722 for ; Fri, 28 Nov 2003 11:20:13 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hASJKDb5098721; Fri, 28 Nov 2003 11:20:13 -0800 (PST) (envelope-from gnats) Resent-Date: Fri, 28 Nov 2003 11:20:13 -0800 (PST) Resent-Message-Id: <200311281920.hASJKDb5098721@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Josh Elsasser Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB6EF16A4CE for ; Fri, 28 Nov 2003 11:13:43 -0800 (PST) Received: from mail.vineyard.net (k1.vineyard.net [204.17.195.90]) by mx1.FreeBSD.org (Postfix) with ESMTP id D718543F93 for ; Fri, 28 Nov 2003 11:13:42 -0800 (PST) (envelope-from joshe@jade.elsasser.org) Received: from localhost (loopback [127.0.0.1]) by mail.vineyard.net (Postfix) with ESMTP id DF15692DF8 for ; Fri, 28 Nov 2003 14:06:54 -0500 (EST) Received: from mail.vineyard.net ([127.0.0.1]) by localhost (king1.vineyard.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 60721-07 for ; Fri, 28 Nov 2003 14:06:54 -0500 (EST) Received: from jade.elsasser.org (loopback [127.0.0.1]) by mail.vineyard.net (Postfix) with ESMTP id 632F292D8E for ; Fri, 28 Nov 2003 14:06:54 -0500 (EST) Received: by jade.elsasser.org (Postfix, from userid 1000) id 75D78E4; Fri, 28 Nov 2003 14:06:53 -0500 (EST) Message-Id: <20031128190653.75D78E4@jade.elsasser.org> Date: Fri, 28 Nov 2003 14:06:53 -0500 (EST) From: Josh Elsasser To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/59768: patch: devfs_link in rc.subr creates link in wrong directory X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2003 19:20:18 -0000 >Number: 59768 >Category: bin >Synopsis: patch: devfs_link in rc.subr creates link in wrong directory >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 28 11:20:13 PST 2003 >Closed-Date: >Last-Modified: >Originator: Josh Elsasser >Release: FreeBSD 5.2-BETA i386 >Organization: >Environment: System: FreeBSD jade.elsasser.org 5.2-BETA FreeBSD 5.2-BETA #5: Thu Nov 27 00:40:17 EST 2003 joshe@jade.elsasser.org:/usr/local/obj/usr/src/sys/JADE i386 >Description: The devfs_link function in /etc/rc.subr ignores it's "dir" argument and instead creates the symlink in ${chroot}/dev. Note that if jail_enable="YES" and jail_foo_devfs_enable="YES" in /etc/rc.conf, this bug will cause /etc/rc.d/jail to trash /dev/console. >How-To-Repeat: Configure a jail in /etc/rc.conf and watch /dev/console disappear: jail_enable="YES" jail_list="foo" jail_foo_rootdir="/foo" jail_foo_hostname="foo" jail_foo_ip="192.168.0.2" jail_foo_exec="/bin/sh /etc/rc" jail_foo_devfs_enable="YES" >Fix: diff -u /etc/rc.subr.orig /etc/rc.subr --- /etc/rc.subr.orig Fri Sep 5 16:54:29 2003 +++ /etc/rc.subr Fri Nov 28 13:50:32 2003 @@ -1058,7 +1058,7 @@ warn "$_me: the directory ($dir) does not exist" return 1 fi - cd ${chroot}/dev + cd "$dir" if ! ln -sf $src $link ; then warn "$_me: unable to link $link --> $src in $dir" return 1 >Release-Note: >Audit-Trail: >Unformatted: