From owner-freebsd-net@FreeBSD.ORG Tue Jul 6 01:25:52 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 59D8E106564A for ; Tue, 6 Jul 2010 01:25:52 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 132E08FC17 for ; Tue, 6 Jul 2010 01:25:51 +0000 (UTC) Received: by iwn35 with SMTP id 35so4503434iwn.13 for ; Mon, 05 Jul 2010 18:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:openpgp:content-type; bh=PDS/gaBFw/4K1cVLwJrPjaz5NO5atAxpjEQYH7Gky6Q=; b=octGP26rYhzDvmPU0PBsYj0vQhXAc8mKDjQwHwvMpR3tZHfA8afmlq7heD99FlCfD2 kF7PVuyC1zYh+3BfgfjB12eOhD0v+VCjkNetZ0SiwUjasS3AwuXu0htInbSWjnL7Itws 0jJ92InfXCnvLxrIxFiYKa7BveQjP3pPmfOvQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:openpgp:content-type; b=pSZNYsYWHUJ5d+SHvBBPVOEsmsY8fUh6xraWgeNschPluuY0B1oBFzk9ZEiI7SnzQl U4bvps99qAFA2zmMjgzRbPxJMSyhpky9n41YHjZV+7WnY8XxkCPgu4cCFrMd5LiBM8i5 7Nm7fUpZGM//oDDj/1UkC5i7pwKbF/wK+Ibd8= Received: by 10.231.39.137 with SMTP id g9mr4100735ibe.133.1278379549982; Mon, 05 Jul 2010 18:25:49 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-128-180.dsl.klmzmi.sbcglobal.net [99.181.128.180]) by mx.google.com with ESMTPS id r3sm20905694ibk.19.2010.07.05.18.25.47 (version=SSLv3 cipher=RC4-MD5); Mon, 05 Jul 2010 18:25:48 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C32861B.4060203@dataix.net> Date: Mon, 05 Jul 2010 21:25:47 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.10) Gecko/20100626 Thunderbird MIME-Version: 1.0 To: Earl Lapus References: In-Reply-To: X-Enigmail-Version: 1.0.1 OpenPGP: id=89D8547E Content-Type: multipart/mixed; boundary="------------090608030906040104080003" Cc: freebsd-net@freebsd.org Subject: Re: patch review for kern/146534 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2010 01:25:52 -0000 This is a multi-part message in MIME format. --------------090608030906040104080003 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/04/2010 04:00, Earl Lapus wrote: > Hi, > > I just want to follow-up on this PR. Basically a working icmp6 > functionality that exists in 7.x and below broke in 8.x and CURRENT. I > believe it's too late to have it fixed in 8.1. Maybe someone on the > list that really knows the icmp6 code can have a look and verify if it > is indeed a bug. If it is, hopefully it can be fixed on the next > releases. > > Cheers! > Earl > > I have reviewed this, edited the patch and determined this does fix the problem. The patch is attached and is also here: http://bit.ly/clqhxt Regards, - -- +-+-+-+-+-+ |j|h|e|l|l| +-+-+-+-+-+ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iQEcBAEBAgAGBQJMMoYaAAoJEJBXh4mJ2FR+dN0H/jGb6K6NiWJuRDjfg+hUBebm AXfUvhrIyD0SKriaCVM9+ZymkfrgDBzRGWKZ61I7K3ZH/shhbII0NoS+VxFa9sqN ZuWu/2zDbuyY36+OjRWMreNuXns3/LEm6VxHlo8JbGBAtk0d1BPM3MqrV5JPP0W1 pqy0db3NOqqNMADsK7GYdAfI65cgx+05XuhmKZ86fCsfnd7EkPcFVIGZrJxoT8HB P7VhtfsxsEwakTMhbcgXltQggWKhGtMKzjscAe5n6ncd5Aq22JjKdPZHTcin8mLi htqynqfmTcs88D0nG0/m6344HXPFOe16vCRJmJGBvR0wBbICEycBZZtsqgmbqiU= =huMJ -----END PGP SIGNATURE----- --------------090608030906040104080003 Content-Type: text/x-patch; name="icmp6-ll-Fix-r209700.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="icmp6-ll-Fix-r209700.diff" Index: sys/netinet6/icmp6.c =================================================================== --- sys/netinet6/icmp6.c (revision 209700) +++ sys/netinet6/icmp6.c (working copy) @@ -2162,8 +2162,21 @@ } if ((srcp != NULL) && - (in6_addrscope(srcp) != in6_addrscope(&ip6->ip6_src))) - srcp = NULL; + (in6_addrscope(srcp) != in6_addrscope(&ip6->ip6_src))) { + struct sockaddr_in6 sin6; + + bzero(&sin6, sizeof(sin6)); + sin6.sin6_family = AF_INET6; + sin6.sin6_len = sizeof(sin6); + sin6.sin6_addr = origdst; + + ia = (struct in6_ifaddr *) + ifa_ifwithaddr((struct sockaddr *)&sin6); + + if (ia && (ia->ia6_flags & IN6_IFF_ANYCAST)) + srcp = NULL; + } + if (srcp == NULL) { int e; --------------090608030906040104080003 Content-Type: application/octet-stream; name="icmp6-ll-Fix-r209700.diff.sig" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="icmp6-ll-Fix-r209700.diff.sig" iQEcBAABAgAGBQJMMoYaAAoJEJBXh4mJ2FR+nI0H/R6RZQ5O/atXBhBzd+OR5kE2NDhGlC01 gOqTC/TfLbp3sJTx/eN4yZPvrFAtr0FgF58BMDZC9TKi1rVzVmJbZZofRx1b5OTayMDOREMv mKPgkwjDeTOZfX3Dlx/79Z3PgpaZgFNKard5p9ESAqtnv9yQKfpTDS9gjpk86GtQFbgZSlaB +6xzUgzRLbzG0AEZ72otFnI1PTrSjmfZlrbnx0ZDpQs3M5cMQAEnkbe3AsMnYggib3gFbdbK TMAieiEBon+lt6ZDUtq6LFSx2JB1JvTRzfX3QRhjRyO/F8sfTabFYuj+vuaJe1rzpVuzfe0T BYGdbNeWhaQCdmhPKPp5Iq4= --------------090608030906040104080003--