From nobody Thu Dec 29 21:19:39 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Njh9T00H8z1HxH0; Thu, 29 Dec 2022 21:19:41 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (mail.karels.net [216.160.39.52]) by mx1.freebsd.org (Postfix) with ESMTP id 4Njh9S4xFxz3pPV; Thu, 29 Dec 2022 21:19:40 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.16.1/8.16.1) with ESMTP id 2BTLJddc073029; Thu, 29 Dec 2022 15:19:39 -0600 (CST) (envelope-from mike@karels.net) Received: from [10.0.2.130] ([10.0.1.1]) by mail.karels.net with ESMTPSA id WxUAOWsErmNDHQEA4+wvSQ (envelope-from ); Thu, 29 Dec 2022 15:19:39 -0600 From: Mike Karels To: Konstantin Belousov Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 68912701700c - main - ffs_suspend.c: clean up includes Date: Thu, 29 Dec 2022 15:19:39 -0600 X-Mailer: MailMate (1.14r5921) Message-ID: In-Reply-To: <202212292056.2BTKuOIu047460@gitrepo.freebsd.org> References: <202212292056.2BTKuOIu047460@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4Njh9S4xFxz3pPV X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:209, ipnet:216.160.36.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 29 Dec 2022, at 14:56, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D68912701700ca3230f3e2d4b= 7858a038f884a327 > > commit 68912701700ca3230f3e2d4b7858a038f884a327 > Author: Konstantin Belousov > AuthorDate: 2022-12-28 18:17:53 +0000 > Commit: Konstantin Belousov > CommitDate: 2022-12-29 20:55:39 +0000 > > ffs_suspend.c: clean up includes > > Order includes alphabetically. > Remove unneeded sys/param.h, it is already included by sys/systm.h.= I am surprised by the last change; it seems contrary to the spirit (at least) of style(9). In particular, style(9) says that param.h or types.h= goes first (or after cdefs.h), followed by systm.h if needed. I don=E2=80= =99t object to direct inclusion of param.h even if one of the 14 other headers= in sys/ that include param.h are also included. Mike > Reviewed by: mckusick > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D37896 > --- > sys/ufs/ffs/ffs_suspend.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/sys/ufs/ffs/ffs_suspend.c b/sys/ufs/ffs/ffs_suspend.c > index d13097109758..e7c976b6e921 100644 > --- a/sys/ufs/ffs/ffs_suspend.c > +++ b/sys/ufs/ffs/ffs_suspend.c > @@ -33,15 +33,14 @@ > #include > __FBSDID("$FreeBSD$"); > > -#include > #include > #include > -#include > -#include > -#include > #include > +#include > #include > +#include > #include > +#include > > #include