From owner-freebsd-stable@freebsd.org  Thu Jul  5 13:58:31 2018
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3E0D102BED1
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Thu,  5 Jul 2018 13:58:31 +0000 (UTC)
 (envelope-from petefrench@ingresso.co.uk)
Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 49FF37DF4B;
 Thu,  5 Jul 2018 13:58:31 +0000 (UTC)
 (envelope-from petefrench@ingresso.co.uk)
Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk)
 by constantine.ingresso.co.uk with esmtpsa
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD))
 (envelope-from <petefrench@ingresso.co.uk>)
 id 1fb4mD-0002gb-SM; Thu, 05 Jul 2018 13:58:29 +0000
Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91
 (FreeBSD)) (envelope-from <petefrench@ingresso.co.uk>)
 id 1fb4mD-0006j7-SY; Thu, 05 Jul 2018 14:58:29 +0100
To: kostikbel@gmail.com, petefrench@ingresso.co.uk
Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround)
Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org,
 freebsd@hda3.com, truckman@FreeBSD.org
In-Reply-To: <20180705133542.GG5562@kib.kiev.ua>
Message-Id: <E1fb4mD-0006j7-SY@dilbert.ingresso.co.uk>
From: Pete French <petefrench@ingresso.co.uk>
Date: Thu, 05 Jul 2018 14:58:29 +0100
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jul 2018 13:58:31 -0000

> This is true, but absolutely irrelevant.
>
> Modern CPUs have hundreds, if not thousands, MSR registers.  Only some of
> them define architectural state, and saved/restored on the context switches.
> Chicken bits are global knobs not relevant to the vmm entry.

That actually makes far more sense. I was kind of puzzled as to how it
would work if they were per VM :-)

> Which other files ?

sys/x86/include/specialreg.h and sys/x86/x86/cpu_machdep.c

Those are in your original patch as well as the change
to sys/amd64/amd64/initcpu.c, but your email earlier only
patches sys/amd64/amd64/initcpu.c and not the others.

So I assumed I would keep the changes to the other two files ?

-pete.