From owner-svn-src-head@FreeBSD.ORG Wed Jan 13 00:15:21 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53DE4106566B for ; Wed, 13 Jan 2010 00:15:21 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 04CE18FC13 for ; Wed, 13 Jan 2010 00:15:20 +0000 (UTC) Received: (qmail 24428 invoked by uid 399); 13 Jan 2010 00:15:20 -0000 Received: from localhost (HELO ?192.168.0.110?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 13 Jan 2010 00:15:20 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B4D109A.5060500@FreeBSD.org> Date: Tue, 12 Jan 2010 16:15:22 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 MIME-Version: 1.0 To: "M. Warner Losh" References: <201001101744.o0AHiM2d095302@svn.freebsd.org> <20100110.210204.787670930858346133.imp@bsdimp.com> In-Reply-To: <20100110.210204.787670930858346133.imp@bsdimp.com> X-Enigmail-Version: 1.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-arch@FreeBSD.org Subject: INCLUDE_CONFIG_FILE in GENERIC X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2010 00:15:21 -0000 On 1/10/2010 8:02 PM, M. Warner Losh wrote: > In message: > Doug Barton writes: > : On Sun, 10 Jan 2010, Warner Losh wrote: > : > : > Author: imp > : > Date: Sun Jan 10 17:44:22 2010 > : > New Revision: 202019 > : > URL: http://svn.freebsd.org/changeset/base/202019 > : > > : > Log: > : > Add INCLUDE_CONFIG_FILE in GENERIC on all non-embedded platforms. > : > : Thanks for doing this, however the comment about how to include the > : whole file (including the comments) were not included. Do I need to do > : this part of it myself? No problem if so, I just want to be sure to > : get it done in time to MFC it before the freeze for 7.3-release. > > In general, we don't put big comments like that in the config files, > preferring to leave them to NOTES. I was just following that > convention... Understood, however given that there is plenty of room for confusion on this point because the default is NOT to include the comments I think that some explanation is justified. My original text was: # Store the plain version of the configuration file in the kernel itself. # To store the entire file, including comments, put this in /etc/src.conf: # CONFIGARGS= -C # See config(8) for more details. I'm open to suggestions on shrinking it, but I do think some sort of explanation is warranted. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso