From owner-cvs-all@FreeBSD.ORG Tue Apr 25 19:44:10 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 206ED16A425; Tue, 25 Apr 2006 19:44:10 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C15543D55; Tue, 25 Apr 2006 19:44:09 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k3PJi6uM084672; Tue, 25 Apr 2006 13:44:07 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <444E7BFE.4040800@samsco.org> Date: Tue, 25 Apr 2006 13:43:58 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200604251918.k3PJImQA007820@repoman.freebsd.org> <444E7750.206@samsco.org> <200604251540.00170.jhb@freebsd.org> In-Reply-To: <200604251540.00170.jhb@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2006 19:44:10 -0000 John Baldwin wrote: > On Tuesday 25 April 2006 15:24, Scott Long wrote: > >>John Baldwin wrote: >> >>>jhb 2006-04-25 19:18:48 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/bce if_bcereg.h >>> Log: >>> Fix half of the current i386 tinderbox failure. max_bus_addr should be a >>> bus_addr_t rather than a bus_size_t. >>> >>> Revision Changes Path >>> 1.2 +1 -1 src/sys/dev/bce/if_bcereg.h >> >>Actually, bus_size_t should also be aware of PAE. > > > That may be true as well, I'll defer to your judgement on that one. In > this case bus_dma_tag_create()'s low_addr argument is supposed to be a > bus_addr_t according to the man page. :) > Both the lowaddr and highaddr arguments are bus_addr_t. The more I think about it, the boundary argument should really be a bus_addr_t. Scott