From owner-freebsd-current  Sat Mar  6  9:36:53 1999
Delivered-To: freebsd-current@freebsd.org
Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141])
	by hub.freebsd.org (Postfix) with ESMTP id 71E601526A
	for <current@FreeBSD.ORG>; Sat,  6 Mar 1999 09:36:50 -0800 (PST)
	(envelope-from nate@mt.sri.com)
Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100])
	by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id KAA15526;
	Sat, 6 Mar 1999 10:36:31 -0700 (MST)
	(envelope-from nate@rocky.mt.sri.com)
Received: by mt.sri.com (SMI-8.6/SMI-SVR4)
	id KAA24445; Sat, 6 Mar 1999 10:36:21 -0700
Date: Sat, 6 Mar 1999 10:36:21 -0700
Message-Id: <199903061736.KAA24445@mt.sri.com>
From: Nate Williams <nate@mt.sri.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: John Polstra <jdp@polstra.com>
Cc: green@unixhelp.org, current@FreeBSD.ORG
Subject: Re: callout changes nit
In-Reply-To: <199903061641.IAA44512@vashon.polstra.com>
References: <Pine.BSF.4.05.9903061057250.11342-100000@janus.syracuse.net>
	<199903061641.IAA44512@vashon.polstra.com>
X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> > I make a habit of checking out any interesting kernel changes in full, and one
> > thing I found in the recent diff by Mr. Wollman for kern_timeout.c is:
> > 
> > +void
> > +callout_init(c)
> > +       struct  callout *c;
> > +{
> > +       bzero(c, sizeof c);
> >  }
> > 
> > That doesn't look correct, does it?
> 
> Agreed.  I think it should be "sizeof *c".

Ahh, I see.  I think it should say

       bzero(c, sizeof(struct callout));

To avoid the compiler using the size of the pointers et. al.


Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message