Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Mar 2024 08:50:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 277348] x11/wmctrl: upstream no longer exists
Message-ID:  <bug-277348-7788-GD3FxTx0mf@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-277348-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-277348-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277348

Felix Palmen <zirias@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zirias@freebsd.org
             Status|New                         |Open
           Assignee|ports-bugs@FreeBSD.org      |zirias@freebsd.org

--- Comment #2 from Felix Palmen <zirias@freebsd.org> ---
Hi and thanks for your contribution!

First I have a question: Did you attempt to contact the original upstream
maintainer? If not, could you please do so? I think it's important because
otherwise, it's unclear whether "wmctrl-1.09" would refer to your fork or m=
aybe
to some other fork.

If the original upstream maintainer isn't available, or unwilling to pass
upstream maintainership, I'd very much prefer a different name (maybe just
adding some prefix or suffix) to avoid any confusion. Or maybe as another
option, host the original distfile somewhere along with a patch to make it =
work
(and then of course keep the version at 1.07).

This aside, you probably want to clean your github fork from all GNU autoto=
ols
generated files. To avoid having to use USES=3Dautoreconf, the best option =
is to
generate an actual disfile (IIRC GNU autotools supports "make dist" for tha=
t)
and upload it to a release on github ... thus also avoiding the need for
USE_GITHUB=3Dyes.

Finally, at a first glance, please don't add to variables when not needed, =
like
here:

USE_XORG=3D       x11 xmu xext xt
USE_XORG+=3D      ice
USE_XORG+=3D      sm

The correct way would be

USE_XORG=3D       ice sm x11 xext xmu xt

(alphabetically sorted)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-277348-7788-GD3FxTx0mf>