From owner-cvs-all@FreeBSD.ORG  Sun Jan  9 05:25:03 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 00F1916A4CE; Sun,  9 Jan 2005 05:25:03 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E40BA43D45; Sun,  9 Jan 2005 05:25:02 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j095P2OS042571;
	Sun, 9 Jan 2005 05:25:02 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j095P2hZ042570;
	Sun, 9 Jan 2005 05:25:02 GMT
	(envelope-from rwatson)
Message-Id: <200501090525.j095P2hZ042570@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sun, 9 Jan 2005 05:25:02 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netipx spx_usrreq.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Jan 2005 05:25:03 -0000

rwatson     2005-01-09 05:25:02 UTC

  FreeBSD src repository

  Modified files:
    sys/netipx           spx_usrreq.c 
  Log:
  Clean up return handling for a number of SPX-related routines that
  were derived from more complex TCP versions of the same:
  
  - spx_close(), spx_disconnect(), spx_drop(), and spx_usrclosed() all
    always free's the spxpcb invalidating the argument, so a return
    value is not required to indicate if it has.
  - Annotate that the cb arguments to each of these functions is
    invalidated via a comment.
  - When tearing down a pcb due to sonewconn() having failed, mark the
    cb as NULL; later, when deciding whether to store trace information
    due to SO_DEBUG, check that cb is not NULL before dereferencing or
    a NULL pointer dereference may occur.
  
  MFC after:      3 weeks
  
  Revision  Changes    Path
  1.60      +29 -22    src/sys/netipx/spx_usrreq.c