From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 15 17:42:25 2005 Return-Path: X-Original-To: freebsd-bugs@freebsd.org Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EE1016A41C for ; Fri, 15 Jul 2005 17:42:25 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CFEE43D45 for ; Fri, 15 Jul 2005 17:42:25 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j6FHgEC0007328; Fri, 15 Jul 2005 10:42:14 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j6FHg9Fm007326; Fri, 15 Jul 2005 10:42:09 -0700 Date: Fri, 15 Jul 2005 10:42:09 -0700 From: Brooks Davis To: Sean Winn Message-ID: <20050715174209.GB337@odin.ac.hmc.edu> References: <200507142350.j6ENoLjY089474@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <200507142350.j6ENoLjY089474@freefall.freebsd.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: freebsd-bugs@freebsd.org Subject: Re: bin/83468: imported OpenBSD dhclient handles hostnames differently to ISC DHCP 3 - come through as hex X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2005 17:42:25 -0000 --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable It seem likely the proposed patch breaks options that should be in hex (after all, 0x00 is perfectly valid as the last character in a MAC addrss or similar.) Please try the following change instead. Thanks, Brooks Index: tables.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/cvs/src/sbin/dhclient/tables.c,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 tables.c --- tables.c 7 Jun 2005 04:05:09 -0000 1.1.1.1 +++ tables.c 15 Jul 2005 17:35:49 -0000 @@ -74,7 +74,7 @@ struct option dhcp_options[256] =3D { { "lpr-servers", "IA", &dhcp_universe, 9 }, { "impress-servers", "IA", &dhcp_universe, 10 }, { "resource-location-servers", "IA", &dhcp_universe, 11 }, - { "host-name", "X", &dhcp_universe, 12 }, + { "host-name", "t", &dhcp_universe, 12 }, { "boot-size", "S", &dhcp_universe, 13 }, { "merit-dump", "t", &dhcp_universe, 14 }, { "domain-name", "t", &dhcp_universe, 15 }, --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFC1/VwXY6L6fI4GtQRAihDAJ9PXpQpK186rtR27VXqYdeuRl3gqACgpIh+ wz0txvORnMTZ5H5xJGuNL0w= =IrsX -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--