From owner-cvs-src@FreeBSD.ORG  Sat Jan 14 11:40:33 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F3BE216A41F;
	Sat, 14 Jan 2006 11:40:32 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9411E43D49;
	Sat, 14 Jan 2006 11:40:32 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0EBeWlv061968;
	Sat, 14 Jan 2006 11:40:32 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0EBeWlE061967;
	Sat, 14 Jan 2006 11:40:32 GMT (envelope-from rwatson)
Message-Id: <200601141140.k0EBeWlE061967@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sat, 14 Jan 2006 11:40:32 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/netncp ncp_conn.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2006 11:40:33 -0000

rwatson     2006-01-14 11:40:32 UTC

  FreeBSD src repository

  Modified files:
    sys/netncp           ncp_conn.c 
  Log:
  In ncp_sysctl_connstat(), the SLIST_FOREACH() logic to check 'error'
  resulted in deadcode, as 'error' could never be 0.  What this logic
  was originally meant to handle is not clear -- it's been this way
  (broken) since at least RELENG_4.
  
  Found with:     Coverity Prevent(tm)
  MFC after:      3 days
  
  Revision  Changes    Path
  1.28      +1 -7      src/sys/netncp/ncp_conn.c