From owner-dev-commits-src-all@freebsd.org Tue Mar 16 07:43:44 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1F9D857A98F; Tue, 16 Mar 2021 07:43:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F04zM6L7Nz3RCp; Tue, 16 Mar 2021 07:43:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 12G7hZrf092827 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 16 Mar 2021 09:43:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 12G7hZrf092827 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 12G7hZ5N092826; Tue, 16 Mar 2021 09:43:35 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 16 Mar 2021 09:43:35 +0200 From: Konstantin Belousov To: Emmanuel Vadot Cc: Emmanuel Vadot , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0006530aa14b - main - include: Remove symlink installation Message-ID: References: <202103160613.12G6DLYL061995@gitrepo.freebsd.org> <20210316081214.0ba83981a37b8b3b9e5589bd@bidouilliste.com> <20210316083957.540d3978e5b0160db2104fa1@bidouilliste.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316083957.540d3978e5b0160db2104fa1@bidouilliste.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4F04zM6L7Nz3RCp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 07:43:44 -0000 On Tue, Mar 16, 2021 at 08:39:57AM +0100, Emmanuel Vadot wrote: > On Tue, 16 Mar 2021 09:17:36 +0200 > Konstantin Belousov wrote: > > > On Tue, Mar 16, 2021 at 08:12:14AM +0100, Emmanuel Vadot wrote: > > > On Tue, 16 Mar 2021 08:52:07 +0200 > > > Konstantin Belousov wrote: > > > > > > > On Tue, Mar 16, 2021 at 06:13:21AM +0000, Emmanuel Vadot wrote: > > > > > The branch main has been updated by manu: > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0006530aa14b9df56f88df7d819fae89b115d865 > > > > > > > > > > commit 0006530aa14b9df56f88df7d819fae89b115d865 > > > > > Author: Emmanuel Vadot > > > > > AuthorDate: 2021-03-16 06:12:53 +0000 > > > > > Commit: Emmanuel Vadot > > > > > CommitDate: 2021-03-16 06:12:53 +0000 > > > > > > > > > > include: Remove symlink installation > > > > > > > > > > headers could be installed as symlink to the source tree instead of copies. > > > > > Remove the possibility to do that. > > > > > This make the makefile easier to read and to maintain and also don't duplicate > > > > > code. > > > > > > > > > > While here remove some directories from LSBUDIRS as we already install them using > > > > > the INCS stuff. > > > > > > > > This might make Makefiles easier to read, but also it makes practically > > > > very hard to develop rtld/libc/libthr. After any system header > > > > modification, full buildworld or at least kernel-toolchain run is > > > > required to get buildenv populated with the new headers. > > > > > > Can you share what you did before so I can cook a patch that restore > > > this behavior in a better way than it was done before ? > > > > I did > > $ make buildworld <- this was done relatively irregularly > > $ make buildenv > > [Edit whatever I needed, typically in sys/sys and libexec/rtld-elf] > > $ cd libexec/rtld-elf > > $ make DEBUG_FLAGS=-g WITHOUT_TESTS=yes all > > [Check built ld-elf.so.1, more edits] > > $ make ... > > > > Now, if I modify anything in sys/, I have to repopuate staged headers in > > the obj directory of buildworld. > > Right ok, I've missed that SHARED=symlinks was used in Makefile.inc1, > I'll revert and redo a better patch. Thank you.