From owner-svn-src-all@FreeBSD.ORG  Thu Dec 15 08:26:05 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5E3841065673;
	Thu, 15 Dec 2011 08:26:05 +0000 (UTC)
	(envelope-from bschmidt@techwires.net)
Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 789E58FC16;
	Thu, 15 Dec 2011 08:26:04 +0000 (UTC)
Received: by lahl5 with SMTP id l5so1153467lah.13
	for <multiple recipients>; Thu, 15 Dec 2011 00:26:03 -0800 (PST)
MIME-Version: 1.0
Received: by 10.152.135.195 with SMTP id pu3mr1614265lab.17.1323936168228;
	Thu, 15 Dec 2011 00:02:48 -0800 (PST)
Sender: bschmidt@techwires.net
Received: by 10.152.136.75 with HTTP; Thu, 15 Dec 2011 00:02:48 -0800 (PST)
X-Originating-IP: [79.140.39.245]
In-Reply-To: <201112150052.pBF0qUA5022051@svn.freebsd.org>
References: <201112150052.pBF0qUA5022051@svn.freebsd.org>
Date: Thu, 15 Dec 2011 09:02:48 +0100
X-Google-Sender-Auth: y4KUWmZmD2G4OizYPFFp8isfBX0
Message-ID: <CAAgh0_avwsQ7uzEnwxKtDnnGjck7tJ5AkjqhBYrz2NuRivbbAg@mail.gmail.com>
From: Bernhard Schmidt <bschmidt@freebsd.org>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r228514 - head/sys/net80211
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2011 08:26:05 -0000

On Thu, Dec 15, 2011 at 01:52, Adrian Chadd <adrian@freebsd.org> wrote:
> Author: adrian
> Date: Thu Dec 15 00:52:30 2011
> New Revision: 228514
> URL: http://svn.freebsd.org/changeset/base/228514
>
> Log:
> =A0Modify the ACL code slightly to support a few nifty things:
>
> =A0* Call it before sending probe responses, so the ACL code has the
> =A0 =A0chance to reject sending them.
>
> =A0* Pass the whole frame to the ACL code now, rather than just the
> =A0 =A0destination MAC - that way the ACL module can look at the frame
> =A0 =A0contents to determine what the response should be.
>
> =A0This is part of some uncommitted work to support band steering.
>
> =A0Sponsored by: Hobnob, Inc.
>
> Modified:
> =A0head/sys/net80211/ieee80211_acl.c
> =A0head/sys/net80211/ieee80211_hostap.c
> =A0head/sys/net80211/ieee80211_mesh.c
> =A0head/sys/net80211/ieee80211_proto.h
>
> Modified: head/sys/net80211/ieee80211_acl.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/net80211/ieee80211_acl.c =A0 Wed Dec 14 23:57:47 2011 =A0 =
=A0 =A0 =A0(r228513)
> +++ head/sys/net80211/ieee80211_acl.c =A0 Thu Dec 15 00:52:30 2011 =A0 =
=A0 =A0 =A0(r228514)
> @@ -152,7 +152,8 @@ _acl_free(struct aclstate *as, struct ac
> =A0}
>
> =A0static int
> -acl_check(struct ieee80211vap *vap, const uint8_t mac[IEEE80211_ADDR_LEN=
])
> +acl_check(struct ieee80211vap *vap, const struct ieee80211_frame *wh,
> + =A0 =A0const uint8_t mac[IEEE80211_ADDR_LEN])
> =A0{

Why didn't you remove the mac argument? It is assign from wh->i_addr2
anyways, seems rather too redundant to me.

--=20
Bernhard