From owner-freebsd-current@FreeBSD.ORG Fri May 1 16:51:31 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0485510656A7; Fri, 1 May 2009 16:51:31 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id C774A8FC17; Fri, 1 May 2009 16:51:30 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 52B263378A0; Fri, 1 May 2009 12:51:30 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Fri, 01 May 2009 12:51:30 -0400 X-Sasl-enc: XpFwH6hNPFCwubIgRBd+DAsw+RbGJaFklpZXlJz6y9dw 1241196689 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 9D5A15125; Fri, 1 May 2009 12:51:28 -0400 (EDT) Message-ID: <49FB288E.7070402@incunabulum.net> Date: Fri, 01 May 2009 17:51:26 +0100 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Sam Leffler References: <49E6DB25.2010601@sippysoft.com> <49E6FF8F.4070403@sippysoft.com> <49ED6AD2.4010006@incunabulum.net> <49EDDD51.9040608@freebsd.org> <49FAF3F5.5070609@incunabulum.net> <49FB1A3F.3000809@freebsd.org> <49FB1BE4.20502@freebsd.org> In-Reply-To: <49FB1BE4.20502@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Dennis Melentyev , stable@freebsd.org, "current@freebsd.org" , Maxim Sobolev Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 May 2009 16:51:31 -0000 Sam Leffler wrote: > ... >>>> the "ath_hal" device. >> Do not modify ah_desc.h like you've done. Add this to conf/options >> >> ATH_HAL opt_ah.h >> >> and use that to enable AH_SUPPORT_AR5416. >> > To clarify the first comment: you've made it impossible to build code > w/o the extended format descriptor; this is what I find unacceptable. Ah, of course, duh -- I forgot about the CaPiTalIzAtion of the device name gets pulled into config(5) with the 'device' keyword. Thanks for the reminder... This is a much cleaner fix for the issue than forcing the option to be set on always. It looks like HEAD has this issue too and this can go right in there. Are we happy with AH_SUPPORT_AR5416 being enabled in 7.x GENERIC? The 'out of box' config hasn't been broken by the change and this is identical to to the situation in HEAD as far as I can see. thanks, BMS