From owner-dev-commits-src-main@freebsd.org Fri May 7 16:11:43 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 907AC634019 for ; Fri, 7 May 2021 16:11:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FcFnW3Qh4z4nm6 for ; Fri, 7 May 2021 16:11:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id o5so8987218qkb.0 for ; Fri, 07 May 2021 09:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yYOON+gx0kLhuwQABdXXzEwnzw4kClxxGf4BIbWPRB0=; b=elyi50PbYfOxMK6RUsk4mwyswOEkbtk8Nn7HxP2xp3dq+Gw+dMHygSjGTC2uoHr28x M4DVWepnNQ+IQN3AlWpL0iniH4LpkAtPE+e8RLHzhAWJoaf8Mb916BKEBxVb8cv0m6X9 pqoOclNVmrG1Kr3eALaWQWnlXnjabzv4I2DFPgNNhf7e24jpY0upcZf70KMeuDPvOqa4 b1VsWyE8bCHDIdOXD43xQ6GZRtiiTk5l5fsB+4CG0+1rNqGmN2Lna9mWww9hL2RVqwq3 n9JXBMTv7VYnFqWclFlGqZv0UDzljV+ll9d7rHXQZkwHHEqM6sCEYPaGIbYB8r2SZHfD pbbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yYOON+gx0kLhuwQABdXXzEwnzw4kClxxGf4BIbWPRB0=; b=QSIIIcOxq1myU4M3taVXRXiEwk9f89oJR+ihkGD5NSQE9EVkP6VU2/k2+vMEAjJj2s OCpJc76S4UnVT9pCPkfikabJ48V9EMe1j/INuq4JCB7gslza9aO5fEj9yun1Yo+TZKfB XgIp/iAzzixA61dwmTXQLOM33ZkxpSQMZyh2GtCMWCA4bVfphkiMxhM/2P2OWJGGAjEx 7fFjI8S+0+7yhWmnpCfNqyPAkoJYHVvioNX1gMgHxubobf1dFW9CXXicQjeOKyEKFlpc LNdA2KOEkCTFz7HDNNFZrk/Uobfh/rGfRWkyieWRr19LqI3dMrwcL5Jw6/KMZo8R5nq2 nhOQ== X-Gm-Message-State: AOAM532ugsXd72nRjz0+YM+uzs8BDoKyw1vC/dLa5lXjZKXYNg/7x3bf bTZHqM8VVp/gv3uDkuGTIryGLvFU9WehoXKp8RjRNg== X-Google-Smtp-Source: ABdhPJwGb567mle9BBtrNmsduTo9FXlkjKoVXHI7zlOfgUQzlAVtI1P/bnPfWSiFK7w5BM65+wZfVjfySTMuAX02Tus= X-Received: by 2002:a05:620a:24c5:: with SMTP id m5mr10380213qkn.195.1620403902423; Fri, 07 May 2021 09:11:42 -0700 (PDT) MIME-Version: 1.0 References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Fri, 7 May 2021 10:11:31 -0600 Message-ID: Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. To: Michael Tuexen Cc: Li-Wen Hsu , Randall Stewart , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FcFnW3Qh4z4nm6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 16:11:43 -0000 On Fri, May 7, 2021 at 5:10 AM Michael Tuexen < michael.tuexen@macmic.franken.de> wrote: > > On 7. May 2021, at 11:39, Li-Wen Hsu wrote: > > > > On Thu, May 6, 2021 at 11:26 PM Randall Stewart wrote: > >> > >> The branch main has been updated by rrs: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=5d8fd932e418f03e98b3469c4088a36f0ef34ffe > >> > >> commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > >> Author: Randall Stewart > >> AuthorDate: 2021-05-06 15:22:26 +0000 > >> Commit: Randall Stewart > >> CommitDate: 2021-05-06 15:22:26 +0000 > >> > >> This brings into sync FreeBSD with the netflix versions of rack and > bbr. > >> This fixes several breakages (panics) since the tcp_lro code was > >> committed that have been reported. Quite a few new features are > >> now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the > >> largest). There is also support for ack-war prevention. Documents > >> comming soon on rack.. > >> > >> Sponsored by: Netflix > >> Reviewed by: rscheff, mtuexen > >> Differential Revision: https://reviews.freebsd.org/D30036 > > > > This seems braking LINT kernel build of powerpc: > > > > https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console > > > > Searching "error:" leads to: > > > > 00:08:15.153 > /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: > > error: implicit declaration of function 'tcp_hw_highest_rate' is > > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > 00:08:15.153 high_rate = > > tcp_hw_highest_rate(rack->r_ctl.crte); > > 00:08:15.153 ^ > > > > and > > > > 00:08:15.163 > /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: > > error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is > > invalid in C99 [-Werror,-Wimplicit-function-declaration] > > 00:08:15.163 high_rate = > > tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, > > rack->rc_inp); > > 00:08:15.163 ^ > > > > I suspect this is because RATELIMIT is not defined in default powerpc > > build? Is it safe to enable it? > If you are building TCP stacks, you need RATELIMIT. You can enable it. It > is enabled on > other platforms, too. > Yea. If we can't enable it on powerpc, I have some ideas on how to keep these modules from building when RATELIMIT isn't enabled. Warner