From nobody Wed Aug 13 13:37:45 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c28ZK3FKlz64t92; Wed, 13 Aug 2025 13:37:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c28ZK2Vnsz3SwW; Wed, 13 Aug 2025 13:37:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755092265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IFF/j75GYC7olRkZSvv2sMq2tAbJhJzaDlS5ePmdSAE=; b=rPkUd9djUImFgensiaUZNaC3ZMMoIuxgrAqtgych2m/oRgolza9Wrz2f75e/aC2q7pYni2 Xw+NRSDi10cpIY0kZDz89/rdoQT/UbpbJnz8CGokV86jrua6t+ZK7T8cgcUc6wg6foPUG/ 5MzShXcbqabmH5yGeHxg4ItonXBNTs+ZC2p+yutchlFm9FQVRWftSeihULMtW7l4BsAA6A dPFB64Dj8n+wip+V/pI3BR4aZv8fuL2vVPAAcE+X21yeUR6ZY0aGPkh38ZM53osYz9u/h3 tnANfGOnpcphJ+84ERnPhMs1FB3aCzR/0r+s0m/gnJNqbGYwVwRXODYkdOKkxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755092265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IFF/j75GYC7olRkZSvv2sMq2tAbJhJzaDlS5ePmdSAE=; b=g+qZ8QxD+2i9VtmSeVRR+akD8YiN+ryqdGfvuACyXgcRPFi6hg+0sKvujViK6aMnHScQ1d 6EFhy1RmQ5OUVmJ5OAg1BZnPIvA0roMYMJ2lyD4cwmUjLz5a+XdeR9VqJ4drKJyQvLaN8R u/cf6JoLi0MknWNe9U7rZZJ3NjxN7o6ol3Fdi7p1jbFX9H2YRRUYK1pfLZ73/h4MGOuslQ /kK+EH1gE6pcxgbj6ThOOOHtxSXiKOsbdmgm6gJbtRTd+r+YhBFhxZi2ygeD/+CGAfmCFn uvYBKq1edc2EM1mQTwF/pNnT2xeGwP/TL3SihBOd7yTbWIg5EDhjlFOSinnpkw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755092265; a=rsa-sha256; cv=none; b=VqiizpWdMDKe9nDa2hQ83Dwbzeq07Qr/Rn5ZwDOS8koWEHVK1O3vvTk/pyVXYexqRT5dao 3n72PkNUXQQ9xMp7FUb8iulk7UHy7tVMYIwmoVzyQ8z4urmmbSHlJJ0oqqddSDMOpEoOFE sdPkptXshbLP8cDWdtiRwl6/G4oIeFZ77ZOhcHG9Ba3E5+TG9EaCFPyZTOT6mTjYy8NNfA 7nHkJkJbVYo3id0S0Md/7uA/BLuJabt/1aSw59E8HG5NFWGljUJLg83NeCY9YDCIbben/i cC+UxEdd5WN4kilsKOrxN0ldtkzP0EKlIr3e/UvB/vHP31NuI7dS0py/1KqC1A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c28ZK1dGWz1P4y; Wed, 13 Aug 2025 13:37:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57DDbjxm084579; Wed, 13 Aug 2025 13:37:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57DDbjvb084576; Wed, 13 Aug 2025 13:37:45 GMT (envelope-from git) Date: Wed, 13 Aug 2025 13:37:45 GMT Message-Id: <202508131337.57DDbjvb084576@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: d142a8a4f1ad - stable/14 - if_ovpn: fill out sin_len/sin6_len List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d142a8a4f1ad877e22b37f691066cea7a3fa9e6a Auto-Submitted: auto-generated The branch stable/14 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=d142a8a4f1ad877e22b37f691066cea7a3fa9e6a commit d142a8a4f1ad877e22b37f691066cea7a3fa9e6a Author: Kristof Provost AuthorDate: 2025-07-22 12:41:20 +0000 Commit: Kristof Provost CommitDate: 2025-08-13 13:24:51 +0000 if_ovpn: fill out sin_len/sin6_len When we parse an nvlist sockaddr we should set the sockaddr_in(6)'s length field. This isn't currently used by anything yet, but it's reasonable to expect a sockaddr to contain its length. MFC after: 3 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit e83df5367d30761803e09bd7fcf518638dfe43d2) --- sys/net/if_ovpn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/if_ovpn.c b/sys/net/if_ovpn.c index 7d9c3bb9c951..54d7cbd22c81 100644 --- a/sys/net/if_ovpn.c +++ b/sys/net/if_ovpn.c @@ -363,6 +363,7 @@ ovpn_nvlist_to_sockaddr(const nvlist_t *nvl, struct sockaddr_storage *sa) memset(in, 0, sizeof(*in)); in->sin_family = af; + in->sin_len = sizeof(*in); if (len != sizeof(in->sin_addr)) return (EINVAL); @@ -379,6 +380,7 @@ ovpn_nvlist_to_sockaddr(const nvlist_t *nvl, struct sockaddr_storage *sa) memset(in6, 0, sizeof(*in6)); in6->sin6_family = af; + in6->sin6_len = sizeof(*in6); if (len != sizeof(in6->sin6_addr)) return (EINVAL);