From owner-freebsd-current@FreeBSD.ORG Fri Oct 14 20:31:39 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B2147106564A for ; Fri, 14 Oct 2011 20:31:39 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from argol.doit.wisc.edu (argol.doit.wisc.edu [144.92.197.212]) by mx1.freebsd.org (Postfix) with ESMTP id 830808FC16 for ; Fri, 14 Oct 2011 20:31:39 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) id <0LT200H00P0QD200@smtpauth3.wiscmail.wisc.edu>; Fri, 14 Oct 2011 15:31:38 -0500 (CDT) Received: from anacreon.physics.wisc.edu (anacreon.physics.wisc.edu [128.104.160.176]) by smtpauth3.wiscmail.wisc.edu (Sun Java(tm) System Messaging Server 7u2-7.05 32bit (built Jul 30 2009)) with ESMTPSA id <0LT200GDTP0PYB00@smtpauth3.wiscmail.wisc.edu>; Fri, 14 Oct 2011 15:31:37 -0500 (CDT) Date: Fri, 14 Oct 2011 15:31:36 -0500 From: Nathan Whitehorn In-reply-to: To: "Jayachandran C." Message-id: <4E989C28.3030606@freebsd.org> X-Spam-Report: AuthenticatedSender=yes, SenderIP=128.104.160.176 X-Spam-PmxInfo: Server=avs-14, Version=5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.10.14.202121, SenderIP=128.104.160.176 References: User-Agent: Mozilla/5.0 (X11; U; FreeBSD powerpc; en-US; rv:1.9.2.22) Gecko/20110913 Thunderbird/3.1.14 Cc: Rafal Jaworowski , Marcel Moolenaar , FreeBSD Current Subject: Re: [RFC] FDT fix for 64 bit platforms X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2011 20:31:39 -0000 On 10/14/11 14:10, Jayachandran C. wrote: > I'm planning commit this -CURRENT if there an no objections. > > In the current implementation, phandle is used to store a pointer to > the location inside the device tree. Since phandle_t is u32, this > will not work on 64 bit platforms. With this fix, the phandle is the > offset from the start of device tree pointer 'fdtp', which will be 32 > bit. > > Review or testing from device tree users will be welcome. > > JC. Why not use offsets into the FDT rather than full pointers? I believe having phandles greater than 32 bits violates the FDT spec, and declaring that the FDT can't itself be larger than 4 GB seems reasonable. -Nathan