From owner-freebsd-current@freebsd.org Wed Jun 21 19:04:41 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18506D9747D for ; Wed, 21 Jun 2017 19:04:41 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qt0-x22f.google.com (mail-qt0-x22f.google.com [IPv6:2607:f8b0:400d:c0d::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C46C57AD32; Wed, 21 Jun 2017 19:04:40 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qt0-x22f.google.com with SMTP id u12so164926746qth.0; Wed, 21 Jun 2017 12:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HxrSv2QcaJmyYCzQP20UrbfmOFPk2OElZFkbs/5RbRU=; b=Lr48S+PVR/7FCLNdjBV8Xo2gWby/o/6sAHZXL5jU08QxgBr4oBW/MIuCpCL9p9Mbf3 t3TQBuTYoTeavN0RyQIk1U2dXU0nuDvNf2mlSZEO5v4ZJIuEcIPZ4pRWAgZ4nB8Y4rKf G4HJqMTPYX4v69xTB2SUp3BTor2iWo/WhGr0gjzxRdPG7fuWlUdUt1DC6dFGdOgs4mwJ W/F8Qbofdtg9aF61ZQBchuickQidGtWVg3Tw1gqU/NiS7KnTLb0vUMsFew4j+g4z5uXR oxjJv+Q6b4Z0bvG3jbnqG3HJ+P5T3AbsW/SvAPKqzKb/hMsTKlL85CuBMj/iEAFaVFaW RSrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HxrSv2QcaJmyYCzQP20UrbfmOFPk2OElZFkbs/5RbRU=; b=cfVh45Pw7nwaeB9XH5O4mFbh8ehWa8uA6gEQqfiQMUvafN/YQ1zgbVIRlSzGD+evLA PRGj3/svZYEjMaNZc5L7l1UvT07vnUmg749vDEFSZ2FAwo0fyNLPII111cOakiBYrpMS lhkmHdD5q544jj1C1kOZcsaLKPfd9GfYhuHWUnYk0JrrSPnG9cqXhbrbF4ys0eIePT6a i+TcSLfTl6PpcP2RhtL4mMnJopz9ZSvuM5te26e6Rfu5STOxOeLHPngeJ4T/6m5n2urB pSgotB5ZeaLPi+4z8A76ZpdNp+GPBTVkb657TE0dwn64Eku63sOKrtVA0waJjhUbE+2k da6A== X-Gm-Message-State: AKS2vOx61d8I4ZHpMnkrs9L4Hl0vvBbeCPBnAf7C2xVs0VJfXIURZCqz A5EekaJmnQYvX4E6vYE= X-Received: by 10.237.44.197 with SMTP id g63mr39686216qtd.241.1498071879632; Wed, 21 Jun 2017 12:04:39 -0700 (PDT) Received: from mbp-eth.home ([177.53.86.172]) by smtp.gmail.com with ESMTPSA id d16sm10982490qke.5.2017.06.21.12.04.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2017 12:04:38 -0700 (PDT) Sender: Renato Botelho Subject: Re: Failover Mode Between Ethernet and Wireless Interfaces broken on >= 11 To: Guido Falsi , freebsd-current@freebsd.org References: <1c1e5c6f-35e5-ca14-2e23-5e33d86a5266@FreeBSD.org> From: Renato Botelho Message-ID: <115d8829-c020-1f8d-23e4-fcaae7b91318@FreeBSD.org> Date: Wed, 21 Jun 2017 16:04:36 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 19:04:41 -0000 On 21/06/17 14:56, Guido Falsi wrote: > On 06/21/17 19:48, Renato Botelho wrote: >> I've already sent it to net, but I suspect this is the appropriate place >> to discuss this subject. > [...] >> >> My next attempt was to do the other way round and make lagg to use wlan0 >> mac address instead of em0's. but even doing this my wireless interface >> ended up not working. > > Strange enough, this works for me. My laptop has a bge interface. Maybe > that's relevant. > > [...] >> >> And configured it to use wlan0 mac address on rc.conf: >> >> ifconfig_em0="ether 60:67:20:c5:2d:48 up" >> wlans_iwn0="wlan0" >> ifconfig_wlan0="WPA" >> cloned_interfaces="lagg0" >> ifconfig_lagg0="up laggproto failover laggport em0 laggport wlan0 DHCP" >> >> and it's now working as expected. > > I can confirm this is exactly what I've been doing for a while on my > laptop. As noted before I did not need to patch the kernel to have this > working. Maybe bge is not affected by this bug, interesting. It would be good to know which models are affected > >> >> Other than that, I believe if wlan interfaces cannot have their mac >> address changed, ifconfig should return an error when user attempts to >> do it, and if_setlladdr() should do the same. >> >> Thoughts? > > I agree returning some error code would be nicer on users. > In this case since some drivers are OK and others not, we cannot remove the possibility of changing mac address from ifconfig for all wlan interfaces. I'm wondering if there is any side-effect to have only the change I made applied, not sure if there are reasons to run filters and event_handler when if_setlladdr() is called with the same address that is current set on NIC. -- Renato Botelho