From nobody Mon Jul 28 20:57:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4brW4x02xxz63TL6; Mon, 28 Jul 2025 20:57:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4brW4w6H85z44rf; Mon, 28 Jul 2025 20:57:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753736240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=trwfmtf8lVCC3P40OciiCQagkT/Nzys15Cn51CtHgec=; b=C+ZrLwvx83BZd8zh5NVi6eZE6T2ambYl7FQtZ1h/A94jCI710G/bjFF6TGuXQ5WM8jFxhx kvc75Eqzhk5K3CQ6R6NoSlQg1qRgs5395dO3/KpQNZS5XE1vUoNz6NgHDCCN7YkYnIThDc TkhSjJMwpqGyJvBgX5hqYeSxKVaEyRzo4nhM/fVf6jJIaoFeescebtvlea6OBwXBd+XBkk ncRtoKqMYgcicRD4hZw8X8Re6nbGvpSD2p7zXH40NMoxOQ5s4JyS5jFYqhgLbwf5F9lnb4 XTnZ4YPPiNHduzGODl8h1O2lkh5JkZdkr7Atw3qCzA3JmtQ1ykg143h59NsUTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753736240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=trwfmtf8lVCC3P40OciiCQagkT/Nzys15Cn51CtHgec=; b=kE5w0th4JyWUxGtDiVlhYvaGdREodBQmlRk2EZBC74P0c8xzWxU7VJKMeriM2K1yHYyzYp YBMTI8JGc1iUlkFzLk9HVC1iIM84Tplb6uoRaps4fFstVOFbCvoPAZNXCXpxj1lBkYTv62 lCaij2fWRFNZkriIGQXzdamv2WtGPCcGKac+fMEbW1EtjSjFSbANl0FJdcVzfm2WjyjO5v PiywCNNrg4gSlR7XWBvqp/tyvqhQfzlRICvxavAf6S/Q7lZ4yZGWpz/6QELT/1L+ytW/UE oWuNVcNaYEpg0mjgRrBnGh0+4mQvGS6PQ0U8N6M6jBHxkISO2r2AUAzIONKE+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753736240; a=rsa-sha256; cv=none; b=HMR4rLdblrOiqEDX4CB08Gp9E6XQrj2a9h+fiCFQ/Cof5/pcKr9M1MhoNM/lmg10M8ZiIs o8YT6Y/lhEnGp5jUYzNb477RxGrq4XsmJOVZdZjEWW8Mx10AR6Y+UeeGw3lT5WWGcIVPLh CKj5gktu5E+g34qWnRUzLo/yT5GCvJyX3tfB05kVWP8roAVTH8nBgSfNdsBd27Lzv1HzYB lWedzY3sFjH+fkYHB9cB4GCd70IEJqx0nBuTMqoA8A7xDmMSZLfRoVASkJUe0MvnEoh3nT jydv93HizD64YRqavKgDxNDm7GAmntYJeTR/wio9sIUCJQTbuJT6BdyJUprE3A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4brW4w4Vvkz122t; Mon, 28 Jul 2025 20:57:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56SKvKev019366; Mon, 28 Jul 2025 20:57:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56SKvKt2019363; Mon, 28 Jul 2025 20:57:20 GMT (envelope-from git) Date: Mon, 28 Jul 2025 20:57:20 GMT Message-Id: <202507282057.56SKvKt2019363@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: c069ca085bd1 - main - ufs_vnops.c: use unsigned type for newparent inode number in ufs_rename() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c069ca085bd185eda4a90dc4bc2b76cceb74579d Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=c069ca085bd185eda4a90dc4bc2b76cceb74579d commit c069ca085bd185eda4a90dc4bc2b76cceb74579d Author: Konstantin Belousov AuthorDate: 2025-07-27 13:47:22 +0000 Commit: Konstantin Belousov CommitDate: 2025-07-28 20:57:14 +0000 ufs_vnops.c: use unsigned type for newparent inode number in ufs_rename() Otherwise it is sign-extended into 64bit ino_t on the call to ufs_dirrewrite(). This causes invalid inode number recorded in the SU tracking structures (newdirem) and triggers corresponding panics. Reviewed by: mckusick, olce Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D51573 --- sys/ufs/ufs/ufs_vnops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/ufs/ufs/ufs_vnops.c b/sys/ufs/ufs/ufs_vnops.c index 17308706c3f4..406b8f943077 100644 --- a/sys/ufs/ufs/ufs_vnops.c +++ b/sys/ufs/ufs/ufs_vnops.c @@ -1268,7 +1268,8 @@ ufs_rename( struct inode *fip, *tip, *tdp, *fdp; struct direct newdir; off_t endoff; - int doingdirectory, newparent; + int doingdirectory; + u_int newparent; int error = 0; struct mount *mp; ino_t ino;