From nobody Tue Apr 4 16:34:18 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrYHy2qmPz43qC3; Tue, 4 Apr 2023 16:34:22 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrYHx5NNnz3sbn; Tue, 4 Apr 2023 16:34:21 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.33) smtp.mailfrom=cy.schubert@cschubert.com; dmarc=none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id jiPKpvlLDjvm1jjbwpjBXF; Tue, 04 Apr 2023 16:34:20 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id jjbvpMzX0HFsOjjbwpAZ78; Tue, 04 Apr 2023 16:34:20 +0000 X-Authority-Analysis: v=2.4 cv=XZqaca15 c=1 sm=1 tr=0 ts=642c518c a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=dKHAf1wccvYA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=5EIRqRKFUycIrONGHWwA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id F2C25C80; Tue, 4 Apr 2023 09:34:18 -0700 (PDT) Received: from slippy (localhost [IPv6:::1]) by slippy.cwsent.com (Postfix) with ESMTP id CE07D18A; Tue, 4 Apr 2023 09:34:18 -0700 (PDT) Date: Tue, 4 Apr 2023 09:34:18 -0700 From: Cy Schubert To: Martin Matuska Cc: Rick Macklem , Mateusz Guzik , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled Message-ID: <20230404093418.3041ff23@slippy> In-Reply-To: <20230404091844.639cb1c1@slippy> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> Organization: KOMQUATS X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfOzrGc4i1nl8u5NgB+C0ROe+0yOvdn/qjDunrgLIMzYkNgLfRdjPKU1neh3DP3DVCTGx10AWC06LYd1j3qg+IauqQ6zqQNVtp6TNIgNUqzSiQoiO5lkF kPblsS5YWTz8S/fx4Mm136tptQu50v6vMeZqav18au6YELwGW2vOm6ymLvg7g5C26ZlWQWL+5Ro8ljfui8chOjJCmpVJ3GnKZrTI4kltGVOuUvQ5Mj/PrVBy l6cfSGuKgZAJ2uWg2Q11BAi/70AlHyaZLqb4xltf1VRidDQmF8Br2+fFlNBrTYHpu0x9wh6H+z/JpSthMLUThLT9zFoZ+PPnH7d/xTS4UPsSeHz8F8G6brmn ND4wK40WLu6TmY6hUV3Ln20UReD4ibxE3eZafTATlVf/KK46U3A= X-Spamd-Result: default: False [-0.29 / 15.00]; SUSPICIOUS_RECIPS(1.50)[]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.986]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.33:from]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; TAGGED_RCPT(0.00)[]; R_SPF_NA(0.00)[no SPF record]; RCPT_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; HAS_ORG_HEADER(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4PrYHx5NNnz3sbn X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N The previously posted patch containing the following fixes all regressions discussed so far: - Rick's fix null ap->a_fsizetd NULL pointer derefernce - Rick's call vn_generic_copy_file_range() when block_cloning is disabled - Martin's call vn_generic_copy_file_range() when any other error resulting in EXDEV -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0 On Tue, 4 Apr 2023 09:18:44 -0700 Cy Schubert wrote: > On Tue, 4 Apr 2023 17:30:25 +0200 > Martin Matuska wrote: > > > So I am now a little bit confused - what is the consensus? :-) > > My exmh email client made a mess of that. Let's try this again. > > Rick has posted a patch. Your patch should also be incorporated to work > around other EXDEV errors, but a few lines earlier so it is protected by > the lock. > > There were a couple of typos in Rick's patch (a missing keystroke; > s/ojset/objset/). > > The patch (Rick's null pointer dereference fix, Rick's copy file range > patch plus your copy file range patch) builds fine on amd64 and i386. > Installing and testing it now. > > A combination of all three patches is attached. It's compile tested but is > currently being installed and will be tested when install is completed. >