From owner-svn-src-projects@FreeBSD.ORG Fri Dec 28 03:21:45 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
by hub.freebsd.org (Postfix) with ESMTP id D26002F7;
Fri, 28 Dec 2012 03:21:45 +0000 (UTC)
(envelope-from jeff@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
[IPv6:2001:1900:2254:2068::e6a:0])
by mx1.freebsd.org (Postfix) with ESMTP id B865A8FC08;
Fri, 28 Dec 2012 03:21:45 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qBS3Lj1X040751;
Fri, 28 Dec 2012 03:21:45 GMT (envelope-from jeff@svn.freebsd.org)
Received: (from jeff@localhost)
by svn.freebsd.org (8.14.5/8.14.5/Submit) id qBS3LiM6040747;
Fri, 28 Dec 2012 03:21:44 GMT (envelope-from jeff@svn.freebsd.org)
Message-Id: <201212280321.qBS3LiM6040747@svn.freebsd.org>
From: Jeff Roberson <jeff@FreeBSD.org>
Date: Fri, 28 Dec 2012 03:21:44 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject: svn commit: r244763 - in projects/physbio/sys: cam/scsi dev/arcmsr
dev/mfi dev/mvs
X-SVN-Group: projects
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src " projects"
tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Dec 2012 03:21:45 -0000
Author: jeff
Date: Fri Dec 28 03:21:44 2012
New Revision: 244763
URL: http://svnweb.freebsd.org/changeset/base/244763
Log:
- Eliminate some XXX comments.
- Be more specific about supported data formats in a few cases. Be less
specific in others.
Sponsored by: EMC / Isilon Storage Division
Modified:
projects/physbio/sys/cam/scsi/scsi_target.c
projects/physbio/sys/dev/arcmsr/arcmsr.c
projects/physbio/sys/dev/mfi/mfi_cam.c
projects/physbio/sys/dev/mvs/mvs.c
Modified: projects/physbio/sys/cam/scsi/scsi_target.c
==============================================================================
--- projects/physbio/sys/cam/scsi/scsi_target.c Fri Dec 28 03:18:05 2012 (r244762)
+++ projects/physbio/sys/cam/scsi/scsi_target.c Fri Dec 28 03:21:44 2012 (r244763)
@@ -737,7 +737,7 @@ targsendccb(struct targ_softc *softc, un
* without data are a reasonably common occurance (e.g. test unit
* ready), it will save a few cycles if we check for it here.
*/
- if (((ccb_h->flags & CAM_DATA_ISPHYS) == 0)
+ if (((ccb_h->flags & CAM_DATA_MASK) == CAM_DATA_VADDR)
&& (((ccb_h->func_code == XPT_CONT_TARGET_IO)
&& ((ccb_h->flags & CAM_DIR_MASK) != CAM_DIR_NONE))
|| (ccb_h->func_code == XPT_DEV_MATCH))) {
Modified: projects/physbio/sys/dev/arcmsr/arcmsr.c
==============================================================================
--- projects/physbio/sys/dev/arcmsr/arcmsr.c Fri Dec 28 03:18:05 2012 (r244762)
+++ projects/physbio/sys/dev/arcmsr/arcmsr.c Fri Dec 28 03:21:44 2012 (r244763)
@@ -2099,7 +2099,6 @@ static int arcmsr_iop_message_xfer(struc
(u_int32_t ) pccb->csio.cdb_io.cdb_bytes[7] << 8 |
(u_int32_t ) pccb->csio.cdb_io.cdb_bytes[8];
/* 4 bytes: Areca io control code */
- /* XXX Does not handle alternate data formats. */
if ((pccb->ccb_h.flags & CAM_DATA_MASK) == CAM_DATA_VADDR) {
buffer = pccb->csio.data_ptr;
transfer_len = pccb->csio.dxfer_len;
Modified: projects/physbio/sys/dev/mfi/mfi_cam.c
==============================================================================
--- projects/physbio/sys/dev/mfi/mfi_cam.c Fri Dec 28 03:18:05 2012 (r244762)
+++ projects/physbio/sys/dev/mfi/mfi_cam.c Fri Dec 28 03:21:44 2012 (r244763)
@@ -264,13 +264,6 @@ mfip_cam_action(struct cam_sim *sim, uni
ccbh->status = CAM_REQ_INVALID;
break;
}
- if ((ccbh->flags & CAM_DIR_MASK) != CAM_DIR_NONE) {
- if ((ccbh->flags & CAM_DATA_MASK) != CAM_DATA_VADDR) {
- ccbh->status = CAM_REQ_INVALID;
- break;
- }
- }
-
ccbh->ccb_mfip_ptr = sc;
TAILQ_INSERT_TAIL(&mfisc->mfi_cam_ccbq, ccbh, sim_links.tqe);
mfi_startio(mfisc);
Modified: projects/physbio/sys/dev/mvs/mvs.c
==============================================================================
--- projects/physbio/sys/dev/mvs/mvs.c Fri Dec 28 03:18:05 2012 (r244762)
+++ projects/physbio/sys/dev/mvs/mvs.c Fri Dec 28 03:21:44 2012 (r244763)
@@ -873,7 +873,6 @@ mvs_legacy_intr(device_t dev, int poll)
}
if (ccb->ccb_h.func_code == XPT_ATA_IO) { /* ATA PIO */
ccb->ataio.res.status = status;
- /* XXX PIO does not support alternate data_ptr formats. */
/* Are we moving data? */
if ((ccb->ccb_h.flags & CAM_DIR_MASK) != CAM_DIR_NONE) {
/* If data read command - get them. */