Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 28 Dec 2012 03:21:44 +0000 (UTC)
From:      Jeff Roberson <jeff@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r244763 - in projects/physbio/sys: cam/scsi dev/arcmsr dev/mfi dev/mvs
Message-ID:  <201212280321.qBS3LiM6040747@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jeff
Date: Fri Dec 28 03:21:44 2012
New Revision: 244763
URL: http://svnweb.freebsd.org/changeset/base/244763

Log:
   - Eliminate some XXX comments.
   - Be more specific about supported data formats in a few cases.  Be less
     specific in others.
  
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  projects/physbio/sys/cam/scsi/scsi_target.c
  projects/physbio/sys/dev/arcmsr/arcmsr.c
  projects/physbio/sys/dev/mfi/mfi_cam.c
  projects/physbio/sys/dev/mvs/mvs.c

Modified: projects/physbio/sys/cam/scsi/scsi_target.c
==============================================================================
--- projects/physbio/sys/cam/scsi/scsi_target.c	Fri Dec 28 03:18:05 2012	(r244762)
+++ projects/physbio/sys/cam/scsi/scsi_target.c	Fri Dec 28 03:21:44 2012	(r244763)
@@ -737,7 +737,7 @@ targsendccb(struct targ_softc *softc, un
 	 * without data are a reasonably common occurance (e.g. test unit
 	 * ready), it will save a few cycles if we check for it here.
 	 */
-	if (((ccb_h->flags & CAM_DATA_ISPHYS) == 0)
+	if (((ccb_h->flags & CAM_DATA_MASK) == CAM_DATA_VADDR)
 	 && (((ccb_h->func_code == XPT_CONT_TARGET_IO)
 	    && ((ccb_h->flags & CAM_DIR_MASK) != CAM_DIR_NONE))
 	  || (ccb_h->func_code == XPT_DEV_MATCH))) {

Modified: projects/physbio/sys/dev/arcmsr/arcmsr.c
==============================================================================
--- projects/physbio/sys/dev/arcmsr/arcmsr.c	Fri Dec 28 03:18:05 2012	(r244762)
+++ projects/physbio/sys/dev/arcmsr/arcmsr.c	Fri Dec 28 03:21:44 2012	(r244763)
@@ -2099,7 +2099,6 @@ static int arcmsr_iop_message_xfer(struc
 				(u_int32_t ) pccb->csio.cdb_io.cdb_bytes[7] << 8  |
 				(u_int32_t ) pccb->csio.cdb_io.cdb_bytes[8];
 					/* 4 bytes: Areca io control code */
-	/* XXX Does not handle alternate data formats. */
 	if ((pccb->ccb_h.flags & CAM_DATA_MASK) == CAM_DATA_VADDR) {
 		buffer = pccb->csio.data_ptr;
 		transfer_len = pccb->csio.dxfer_len;

Modified: projects/physbio/sys/dev/mfi/mfi_cam.c
==============================================================================
--- projects/physbio/sys/dev/mfi/mfi_cam.c	Fri Dec 28 03:18:05 2012	(r244762)
+++ projects/physbio/sys/dev/mfi/mfi_cam.c	Fri Dec 28 03:21:44 2012	(r244763)
@@ -264,13 +264,6 @@ mfip_cam_action(struct cam_sim *sim, uni
 			ccbh->status = CAM_REQ_INVALID;
 			break;
 		}
-		if ((ccbh->flags & CAM_DIR_MASK) != CAM_DIR_NONE) {
-			if ((ccbh->flags & CAM_DATA_MASK) != CAM_DATA_VADDR) {
-				ccbh->status = CAM_REQ_INVALID;
-				break;
-			}
-		}
-
 		ccbh->ccb_mfip_ptr = sc;
 		TAILQ_INSERT_TAIL(&mfisc->mfi_cam_ccbq, ccbh, sim_links.tqe);
 		mfi_startio(mfisc);

Modified: projects/physbio/sys/dev/mvs/mvs.c
==============================================================================
--- projects/physbio/sys/dev/mvs/mvs.c	Fri Dec 28 03:18:05 2012	(r244762)
+++ projects/physbio/sys/dev/mvs/mvs.c	Fri Dec 28 03:21:44 2012	(r244763)
@@ -873,7 +873,6 @@ mvs_legacy_intr(device_t dev, int poll)
 	}
 	if (ccb->ccb_h.func_code == XPT_ATA_IO) { /* ATA PIO */
 		ccb->ataio.res.status = status;
-		/* XXX PIO does not support alternate data_ptr formats. */
 		/* Are we moving data? */
 		if ((ccb->ccb_h.flags & CAM_DIR_MASK) != CAM_DIR_NONE) {
 		    /* If data read command - get them. */

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212280321.qBS3LiM6040747>