Date: Thu, 30 Jan 2020 10:51:23 -1000 (HST) From: Jeff Roberson <jroberson@jroberson.net> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Hans Petter Selasky <hselasky@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap Message-ID: <alpine.BSF.2.21.9999.2001301046260.1198@desktop> In-Reply-To: <20200130204322.GJ1268@FreeBSD.org> References: <202001301028.00UAS1s1063130@repo.freebsd.org> <20200130204322.GJ1268@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 30 Jan 2020, Gleb Smirnoff wrote: > On Thu, Jan 30, 2020 at 10:28:01AM +0000, Hans Petter Selasky wrote: > H> Author: hselasky > H> Date: Thu Jan 30 10:28:01 2020 > H> New Revision: 357291 > H> URL: https://svnweb.freebsd.org/changeset/base/357291 > H> > H> Log: > H> Widen EPOCH(9) usage in PCI WLAN drivers. > H> > H> Make sure all occurrences of ieee80211_input_xxx() in sys/dev are > H> covered by a network epoch section. Do not depend on the interrupt > H> handler nor any taskqueues being in a network epoch section. > H> > H> This patch should unbreak the PCI WLAN drivers after r357004. > H> > H> Pointy hat: glebius@ > H> Sponsored by: Mellanox Technologies > > Hey, I have reviewed all of them. > > The following drivers were not broken, and your change does 100% > recursive epoch_enter: > > bwi, ipw, iwi, iwm, iwn, ral, rtwn, wi, wpi > > The following drivers use taskq and would be fixed by D23408: > > bwn, malo, mwl, wtap > > P.S. A funny note about wtap. You modified even a function that > is a dead code - wtap_rx_deliver(). Gives some clue on quality > of your sweep over all drivers. I would strongly suggest that we not make more changes to this area without a discussion on a review to make sure we're all in agreement. There are some fine technical details which would benefit from multiple eyes and failing to act together is creating more conflict than is necessary. I volunteer to be on the reviews as an impartial third party. Thanks, Jeff > > -- > Gleb Smirnoff >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.21.9999.2001301046260.1198>