From owner-svn-src-head@freebsd.org Wed May 30 12:10:44 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BD75EF5264 for ; Wed, 30 May 2018 12:10:44 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89CDE7F8C1 for ; Wed, 30 May 2018 12:10:43 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wm0-x230.google.com with SMTP id f6-v6so47432384wmc.4 for ; Wed, 30 May 2018 05:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EbDqWsTa4OE0SEOcnEGZnTBZSVhmlXxzrWM4Fmp/ZQA=; b=OM0EVFyhGRWcsdL9B8h963UFLTYvBc8OWTHgXyWz6T/wj20YI+YL8oW0r6oCqqc4mt Z/fi/PlXOuFhByZKnBrpbesWBdSfMzFvOWDtlCeIeyjusGcsnRwny/TJXwtjro/1kgBK ekgSv7k7LmJtjOhEAcByjGWsyMPznQEZy7pHWrbXyuX2xdskE04na1HyDvSsSgRlYF6n 8aXizEuVA3LU3lyRZu85jnhScdoHbsv0C8u/6ppHJG2t71t+GottNA/+zdLIlYfR7etA WQH65ZNfUcNMyZ2ROxaIzaqUBamId+tqwd78E3kZtWXYZe6uHJN9fe4E9+gVvZxmbcq5 mm6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EbDqWsTa4OE0SEOcnEGZnTBZSVhmlXxzrWM4Fmp/ZQA=; b=pQ7r1b6YYxXkoYoFDnDucmVPXErDAmelM6w0EEGejybUHkWf8ePwkEEy4FJM64WNyj GGBF/RImfhA5hHK8ijFKTFFmI+elgjSYQxfc1J+nFG3yJcpE3EX5So5rgpmRiJuxRofh lBX5FPXrvUKmfvLBGq8mOGv+VKZaDbIdxA2NWbn5fYx8cYnWU8t3vUGPnPrzsTzF6zkr EoDrP181RMIEz8WHmcjX1svNX3+GJNrVchVrh5LfUyH1NFOXSac2hXQ85ViLfURPIVLR 9cRnGunDwgyQYqo45+djzWis+HC2B2qO1GoArxPbfyyT4h63Kh/FSR5xm7il6ujppERc D4rw== X-Gm-Message-State: ALKqPwcIdEnO6fhFTDPQpFwKN/158KNZaNk9b0HG+vFyKn8ovo6vvWPc SiF1pb64VFbGU5rtyLFu6Ey/Fg== X-Google-Smtp-Source: ADUXVKIqaD2hwTh/C7lyCKrATPUbCVEUvvVzG63vXCvliJJtaMN4hPXp7Q9YSWpjE6UN9IF/SnC+DA== X-Received: by 2002:a1c:f407:: with SMTP id z7-v6mr1234965wma.143.1527682241891; Wed, 30 May 2018 05:10:41 -0700 (PDT) Received: from mutt-hbsd (62-210-37-82.rev.poneytelecom.eu. [62.210.37.82]) by smtp.gmail.com with ESMTPSA id y11-v6sm36777296wrc.93.2018.05.30.05.10.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 05:10:40 -0700 (PDT) Date: Wed, 30 May 2018 08:10:15 -0400 From: Shawn Webb To: Ed Maste Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334363 - head/usr.bin/elfdump Message-ID: <20180530121015.mpdt6gh45kyriciv@mutt-hbsd> References: <201805300116.w4U1GoWj090163@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pufr72ltxxoexor4" Content-Disposition: inline In-Reply-To: <201805300116.w4U1GoWj090163@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180323 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 12:10:44 -0000 --pufr72ltxxoexor4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 30, 2018 at 01:16:50AM +0000, Ed Maste wrote: > Author: emaste > Date: Wed May 30 01:16:50 2018 > New Revision: 334363 > URL: https://svnweb.freebsd.org/changeset/base/334363 >=20 > Log: > elfdump: chase ABI tag note name change from r232832 > =20 > r232832 changed the ABI tag note name from .note.ABI-tag to .note.tag. > Follow suit in elfdump. > =20 > Elfdump's note parsing is very basic and should be significantly > reworked, but for now just restore the broken functionality. > =20 > PR: 228290 > Submitted by: martin at lispworks.com > MFC after: 1 week >=20 > Modified: > head/usr.bin/elfdump/elfdump.c >=20 > Modified: head/usr.bin/elfdump/elfdump.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/elfdump/elfdump.c Wed May 30 00:36:58 2018 (r334362) > +++ head/usr.bin/elfdump/elfdump.c Wed May 30 01:16:50 2018 (r334363) > @@ -659,7 +659,7 @@ main(int ac, char **av) > case SHT_NOTE: > name =3D elf_get_word(e, v, SH_NAME); > if (flags & ED_NOTE && > - strcmp(shstrtab + name, ".note.ABI-tag") =3D=3D 0) > + strcmp(shstrtab + name, ".note.tag") =3D=3D 0) > elf_print_note(e, v); > break; > case SHT_DYNSYM: I wonder if it would be a good idea to handle .note.ABI-tag and =2Enote.tag so that it can handle binaries compiled both before and after r232832. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --pufr72ltxxoexor4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlsOlKIACgkQaoRlj1JF bu7+kA//aDsIerZl0f8HRNtCWMNTWEYlZP2JLnXJNaj+pvdvwgWfsQmXfshh4qQQ 5p6yFoUMNhRJu8fs+yc6Fy9zPFezmjrvYn/Lk4rwf4gGsIAIeXEs14kGu6+Qbc01 6UKY+4wBfE+aaCne7IM/Uq8Uh9IaRm612p37rTTYRIXCgpND3ml2i2YI/SZ0Aixt Jhk98i+bmvmOlCTtQuN3+QqPK0RUwXZFeIK6PPG22IBxsQu1ZH9TBFt71Cka1PyM +gtCmPEwqgQYUNySLCBEJPJXWt90H02fXM96bEpSQnKhKRCnCtMHQOCJc5vTgF+u xuQRhgoluJMmfjIGYQyZbpyPxXotVABpCTTPux9B8pxAGiPdfehFsSH+CgXmJIT8 VAvkpFwZ54QcO8fJP1+dn7RcxOSRNw1eOe1oFWHmkqRL4hBwgI7ti5xj8ONZmJFr uJf6JPadYTf+TGneAX+EGe4YgwU6pV3Yn+wCLdidTIworqrdlq43JeIyF+sHH6vW xbfy8FhnCT96ajyKFFQ1TnW/NtxBuKqIZOYgU04YL0W13t8K6xSaDfNaF8+dm2fs msetTZD77pNMQpF6Zj69D6MmPH9zboX0fARRgbvIXIy1tw5zB8tCCwn8VIA6GzOU +gK3MnWkfwOqwx6XkSurfsEI4hoMeviSdhtK7UuAR5EKYdx3F9A= =z9T0 -----END PGP SIGNATURE----- --pufr72ltxxoexor4--