From owner-svn-src-head@FreeBSD.ORG  Thu Nov 11 00:29:19 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E476C1065693;
	Thu, 11 Nov 2010 00:29:19 +0000 (UTC)
	(envelope-from cperciva@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id D377A8FC0A;
	Thu, 11 Nov 2010 00:29:19 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oAB0TJPq041906;
	Thu, 11 Nov 2010 00:29:19 GMT
	(envelope-from cperciva@svn.freebsd.org)
Received: (from cperciva@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id oAB0TJPi041904;
	Thu, 11 Nov 2010 00:29:19 GMT
	(envelope-from cperciva@svn.freebsd.org)
Message-Id: <201011110029.oAB0TJPi041904@svn.freebsd.org>
From: Colin Percival <cperciva@FreeBSD.org>
Date: Thu, 11 Nov 2010 00:29:19 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r215105 - head/contrib/binutils/bfd
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Nov 2010 00:29:20 -0000

Author: cperciva
Date: Thu Nov 11 00:29:19 2010
New Revision: 215105
URL: http://svn.freebsd.org/changeset/base/215105

Log:
  Zero the buffer containing the .gnu_debuglink section before writing
  into it.  Prior to this commit the .gnu_debuglink section can have up
  to 3 bytes of uninitialized garbage; as a result, .ko files could
  change vary between builds.
  
  Approved by:	dim
  MFC after:	7 days

Modified:
  head/contrib/binutils/bfd/opncls.c

Modified: head/contrib/binutils/bfd/opncls.c
==============================================================================
--- head/contrib/binutils/bfd/opncls.c	Wed Nov 10 23:45:44 2010	(r215104)
+++ head/contrib/binutils/bfd/opncls.c	Thu Nov 11 00:29:19 2010	(r215105)
@@ -1151,7 +1151,7 @@ bfd_fill_in_gnu_debuglink_section (bfd *
   debuglink_size &= ~3;
   debuglink_size += 4;
 
-  contents = malloc (debuglink_size);
+  contents = bfd_zmalloc (debuglink_size);
   if (contents == NULL)
     {
       /* XXX Should we delete the section from the bfd ?  */