From owner-svn-src-all@freebsd.org Sun Sep 23 17:51:27 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 743611093C88; Sun, 23 Sep 2018 17:51:27 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it1-x136.google.com (mail-it1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 151E77CE26; Sun, 23 Sep 2018 17:51:27 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it1-x136.google.com with SMTP id p79-v6so7766878itp.3; Sun, 23 Sep 2018 10:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jkiTk2rIUo5OTY9iqUZ5LcevOVv+Rdy7EccsuMIJj80=; b=Y040HiV0xkfn4t8lghrHvx/g3k7QxZdFCfxJGiFfAGHTL4OlJ4ZBBnosNb6hPXY5vQ L8wjOAiW3QGkTX33SkZO4Y8fbqTSmEhIgX0xBtsOxAClOTD/fOZnYB533CRO1kUNUDcY EcDcI7clRkkxueOynzb0OiWm2LcDsgcBAswN9CSsQbBjCyR3/IqzMmtGJPZgkXnv//qX qyNnoJWF5v8OMQO4TLNdq2Vt94f9dk4Sec4ICHG6gnCF1whx+6SIYlEo0jE77bVYczCq k1ssdRzMub/d/R68JbTfhJ3GQQXUVXWKdykJV6gEckT0YiyslJPqlU4ioTrEhfRLZyYN KeAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jkiTk2rIUo5OTY9iqUZ5LcevOVv+Rdy7EccsuMIJj80=; b=jBT/BDyJ0vRntB4R/p126y6/GR5L02ExJK8vR2v32E+eoMXPJEJZ8ufP0HHdsUDv9Y qoPQk+bOa1ASe6SVjOHRe+vPBe9nmK9nzKAmY6fm0So6i1YvVbKORBLVLZtWTX9IvVoV dIlY1+bQdNxbDHpAVEkfiodBrMUXBCuSugga8hl4g6g36ugIrHEOVY6U6nXjHROhkDej QTGFIHKCheUheJwvWfpRVN/a5TEVJ25rt39/dvzRp7cYbZ5kWAPznJ2f785Es6Xchscr fgBR3DIYV5fe1phXKsjZ2WJHXp4oTZlLpyRrvbpmfSMj1kufC04WiA/pbY5MRAT0z6ct 3geQ== X-Gm-Message-State: ABuFfoji1Y5ZfFumQdny+t7fCyLV5O5G8iEyBa78rsF7PC+pZAxBFeAM medEqDKhSUMLQPpBSeqFvPgCp9JG4JTWsDRlEDVHbg== X-Google-Smtp-Source: ANB0VdZ6wgiDqjgeYeOit3UWXoSqJaS3Cgorq34nciIj+Obn2kgIqhTZWO/kxBDHF1YgFbXPYkaaGDWwhI6IW5eUmK0= X-Received: by 2002:a24:7cc:: with SMTP id f195-v6mr5518255itf.72.1537725086410; Sun, 23 Sep 2018 10:51:26 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 2002:a6b:fd15:0:0:0:0:0 with HTTP; Sun, 23 Sep 2018 10:51:05 -0700 (PDT) In-Reply-To: <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net> References: <201809211749.w8LHnbap091466@repo.freebsd.org> <8513e11e-f699-70e8-6478-24ee2375326c@delphij.net> From: Ed Maste Date: Sun, 23 Sep 2018 13:51:05 -0400 X-Google-Sender-Auth: 2HFwXmnZdAZqlLelwvYrDg9nOgw Message-ID: Subject: Re: svn commit: r338861 - head/lib/libc To: Xin LI Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2018 17:51:27 -0000 On 21 September 2018 at 16:11, Xin Li wrote: > On 9/21/18 10:49, Ed Maste wrote: >> Author: emaste >> Date: Fri Sep 21 17:49:37 2018 >> New Revision: 338861 >> URL: https://svnweb.freebsd.org/changeset/base/338861 >> >> Log: >> libc: require ifunc-capable linker for amd64/i386 >> >> We expect to introduce optimized libc routines in the near future, >> which requires use of a linker that supports ifuncs. >> >> Approved by: re (gjb, kib) >> Sponsored by: The FreeBSD Foundation >> >> Modified: >> head/lib/libc/Makefile >> >> Modified: head/lib/libc/Makefile >> ============================================================================== >> --- head/lib/libc/Makefile Fri Sep 21 17:44:05 2018 (r338860) >> +++ head/lib/libc/Makefile Fri Sep 21 17:49:37 2018 (r338861) >> @@ -21,6 +21,11 @@ LIBC_ARCH=${MACHINE_ARCH} >> LIBC_ARCH=${MACHINE_CPUARCH} >> .endif >> >> +.if (${LIBC_ARCH} == amd64 || ${LIBC_ARCH} == i386) && \ >> + defined(LINKER_FEATURES) && ${LINKER_FEATURES:Mifunc} == "" >> +.error ${LIBC_ARCH} libc requires linker ifunc support >> +.endif >> + >> # All library objects contain FreeBSD revision strings by default; they may be >> # excluded as a space-saving measure. To produce a library that does >> # not contain these strings, add -DSTRIP_FBSDID (see ) to CFLAGS > > It seems that this would break bootstraping from a FreeBSD -CURRENT > before ifunc? It looks like it needs to be made conditional on the make target as well. I should have a fix tomorrow morning.