From owner-svn-src-head@freebsd.org  Tue Sep  6 19:36:30 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 111C4BC6615;
 Tue,  6 Sep 2016 19:36:30 +0000 (UTC)
 (envelope-from gonzo@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CD43BCC0;
 Tue,  6 Sep 2016 19:36:29 +0000 (UTC)
 (envelope-from gonzo@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u86JaSSk092151;
 Tue, 6 Sep 2016 19:36:28 GMT (envelope-from gonzo@FreeBSD.org)
Received: (from gonzo@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u86JaSBU092150;
 Tue, 6 Sep 2016 19:36:28 GMT (envelope-from gonzo@FreeBSD.org)
Message-Id: <201609061936.u86JaSBU092150@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: gonzo set sender to
 gonzo@FreeBSD.org using -f
From: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
Date: Tue, 6 Sep 2016 19:36:28 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r305492 - head/sys/arm/ti
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Sep 2016 19:36:30 -0000

Author: gonzo
Date: Tue Sep  6 19:36:28 2016
New Revision: 305492
URL: https://svnweb.freebsd.org/changeset/base/305492

Log:
  Let knlist_add do the locking part
  
  Remove explicit mtx_lock/mtx_unlock around knlist_add and pass 0 as
  locked parameter so knlist_add does the locking itself
  
  Suggested by:	kib@

Modified:
  head/sys/arm/ti/ti_pruss.c

Modified: head/sys/arm/ti/ti_pruss.c
==============================================================================
--- head/sys/arm/ti/ti_pruss.c	Tue Sep  6 19:29:14 2016	(r305491)
+++ head/sys/arm/ti/ti_pruss.c	Tue Sep  6 19:36:28 2016	(r305492)
@@ -310,9 +310,7 @@ ti_pruss_kqfilter(struct cdev *cdev, str
 	case EVFILT_READ:
 		kn->kn_hook = sc;
 		kn->kn_fop = &ti_pruss_kq_read;
-		mtx_lock(&sc->sc_mtx);
-		knlist_add(&sc->sc_selinfo.si_note, kn, 1);
-		mtx_unlock(&sc->sc_mtx);
+		knlist_add(&sc->sc_selinfo.si_note, kn, 0);
 		break;
 	default:
 		return (EINVAL);