From owner-cvs-all Tue May 21 6:53:19 2002 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id CE7BB37B400; Tue, 21 May 2002 06:53:07 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g4LDqu815460; Tue, 21 May 2002 16:52:56 +0300 (EEST) (envelope-from ru) Date: Tue, 21 May 2002 16:52:56 +0300 From: Ruslan Ermilov To: "J. Mallett" Cc: Mike Barcroft , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/elf2aout elf2aout.c Message-ID: <20020521135256.GA10621@sunbay.com> References: <200205200756.g4K7ueM28492@freefall.freebsd.org> <20020520125748.E8089@espresso.q9media.com> <20020521074034.GB53675@sunbay.com> <20020521042755.B56179@espresso.q9media.com> <20020521093456.GA74330@sunbay.com> <20020521133802.GB5716@FreeBSD.ORG> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline In-Reply-To: <20020521133802.GB5716@FreeBSD.ORG> User-Agent: Mutt/1.3.99i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 21, 2002 at 01:38:03PM +0000, J. Mallett wrote: > On Tue, May 21, 2002 at 12:34:56PM +0300, Ruslan Ermilov wrote: > > > > You'll have to fix first. Also make sure this > > > > still can be bootstrapped from the old versions. > > >=20 > > > Well it looks like the structure you changed is for aout information, > > > so I don't see how would be significant. But even if it > > > were, u_int32_t and uint32_t will always be compatible with each > > > other. The only difference being that the latter is portable, which > > > is a positive attribute for cross-tools. > > >=20 > > I know, I was trying to point that still uses an old > > non-portable u_int32_t, and probably should also be fixed. >=20 > You just lamented having to do 'make includes'. >=20 > Now, consider that when bootstrapping we use the host includes. I doubt a > host uses types it doesn't understand. >=20 Yes, so what? How changing src/sys/sys/elf32.h to use uint32_t breaks bootstrapping? (We don't use it during bootstrapping.) > Think through whether or not changing our header will make a shred of > difference. >=20 Changing elf2aout.c to use uint32_t may make a difference, yes, as it is the bootstrap-tool, but FreeBSD supported uint32_t since at least FreeBSD 3.1 (sys/sys/inttypes.h,v 1.1), and we don't really support upgrading from such an old system straight to 5.0. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE86lE4Ukv4P6juNwoRAtsVAKCLF8wa2+5HZeFLnsSnDZaQBQVmcACfSxWM 22q2RMMgYaJ7MlmeAGLBBf8= =Ti6+ -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message