Date: Tue, 18 Mar 2014 16:49:12 GMT From: Dominic Fandrey <kamikaze@bsdforen.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/187702: [patch] www/chromiu fails with CC/CXX containing spaces Message-ID: <201403181649.s2IGnCg3007697@cgiserv.freebsd.org> Resent-Message-ID: <201403181650.s2IGo0TN096585@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 187702
>Category: ports
>Synopsis: [patch] www/chromiu fails with CC/CXX containing spaces
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 18 16:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Dominic Fandrey
>Release: stable/10
>Organization:
private
>Environment:
FreeBSD AprilRyan.norad 10.0-STABLE FreeBSD 10.0-STABLE #0 r262341: Sat Feb 22 21:52:47 CET 2014 root@fooobar:/usr/obj/GENERIC/amd64/usr/src/sys/GENERIC amd64
>Description:
Build fails when CC/CXX contain spaces.
…
./build/gyp_chromium chrome/chrome.gyp --depth .
cc: error: unsupported option '--depth'
cc: error: no such file or directory: 'CXX=env'
cc: error: no such file or directory: 'c++'
cc: error: no such file or directory: 'GYP_GENERATORS=ninja'
cc: error: no such file or directory: 'GYP_DEFINES=use_cups=1 use_system_yasm=1 use_system_libxml=1 use_system_ffmpeg=0 use_system_libusb=1 use_system_libevent=1 use_system_libvpx=0 linux_breakpad=0 linux_strip_binary=1 linux_use_tcmalloc=0 linux_use_heapchecker=0 test_isolation_mode=noop clang_use_chrome_plugins=0 disable_nacl=1 enable_webrtc=1 enable_openmax=1 enable_one_click_signin=1 werror= no_gc_sections=1 os_ver=1000702 prefix_dir=/usr/local python_ver=2.7 google_api_key=AIzaSyBsp9n41JLW8jCokwn7vhoaMejDFRd1mp8 google_default_client_id=996322985003.apps.googleusercontent.com google_default_client_secret=IR1za9-1VK0zZ0f_O8MVFicn ffmpeg_branding=Chrome proprietary_codecs=1 use_pulseaudio=0 buildtype=Official clang=1'
cc: error: no such file or directory: 'PYTHON=/usr/local/bin/python2.7'
cc: error: no such file or directory: 'PKG_CONFIG=pkgconf'
cc: error: no such file or directory: 'AR=/usr/bin/ar'
cc: error: no such file or directory: 'CFLAGS=-O2 -pipe -march=native -fno-stack-protector -Wno-unknown-warning-option -fno-strict-aliasing'
cc: error: no such file or directory: 'CPPFLAGS='
cc: error: no such file or directory: 'CXXFLAGS=-O2 -pipe -march=native -fno-stack-protector -Wno-unknown-warning-option -fno-strict-aliasing'
cc: error: no such file or directory: 'LDFLAGS='
cc: error: no such file or directory: 'SHELL=/bin/sh'
cc: error: no such file or directory: 'CONFIG_SHELL=/bin/sh'
*** Error code 1
Stop.
make[1]: stopped in /usr/ports/www/chromium
*** Error code 1
Stop.
make: stopped in /usr/ports/www/chromium
>How-To-Repeat:
# cd /usr/ports/www/chromium
# make CC="env cc" CXX="env c++"
>Fix:
Patch attached with submission follows:
Index: www/chromium/Makefile
===================================================================
--- www/chromium/Makefile (revision 348549)
+++ www/chromium/Makefile (working copy)
@@ -139,8 +139,8 @@
GYP_DEFINES+= buildtype=Official
.endif
-CONFIGURE_ENV+= CC=${CC} \
- CXX=${CXX} \
+CONFIGURE_ENV+= CC=${CC:Q} \
+ CXX=${CXX:Q} \
GYP_GENERATORS=ninja \
GYP_DEFINES="${GYP_DEFINES}"
MAKE_ENV+= BUILDTYPE=${BUILDTYPE} \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403181649.s2IGnCg3007697>