From owner-freebsd-bugs@FreeBSD.ORG Tue May 30 09:18:57 2006 Return-Path: X-Original-To: freebsd-bugs@freebsd.org Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6ED1116A528 for ; Tue, 30 May 2006 09:18:57 +0000 (UTC) (envelope-from Susan.Lan@zyxel.com.tw) Received: from zyadd226.zyxel.com.tw (zyadd226.zyxel.com.tw [61.222.65.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CB2643D46 for ; Tue, 30 May 2006 09:18:55 +0000 (GMT) (envelope-from Susan.Lan@zyxel.com.tw) Received: from zytwbe01.zyxel.com ([172.23.5.10]) by smtp.zyxel.com.tw with InterScan Messaging Security Suite; Tue, 30 May 2006 17:26:56 +0800 Received: from zytwfe01.ZyXEL.com ([172.23.5.5]) by zytwbe01.zyxel.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 30 May 2006 17:18:48 +0800 Received: from [172.23.17.39] ([172.23.17.39]) by zytwfe01.ZyXEL.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 30 May 2006 17:18:48 +0800 Message-ID: <447C0DFF.8050500@zyxel.com.tw> Date: Tue, 30 May 2006 17:18:55 +0800 From: Blue User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-bugs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 30 May 2006 09:18:48.0647 (UTC) FILETIME=[0F178570:01C683CA] Subject: Critical section in in6_setsockaddr and in6_setpeeraddr X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 09:19:00 -0000 Hi, All: In in6_setpeeraddr and in6_setsockaddr in in6_pcb.c, the critical section still uses legacy splnet() and splx(). However, the splnet() and splx() have been redefined as empty function. Don't we need to rewrite the part with INP_LOCK(inp); .... INP_UNLOCK(inp);? Best regards, blue