From owner-freebsd-current@freebsd.org Thu Apr 25 03:46:57 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBE91158AC78 for ; Thu, 25 Apr 2019 03:46:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 77CF58E116; Thu, 25 Apr 2019 03:46:56 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52d.google.com with SMTP id z9so10441249pgu.10; Wed, 24 Apr 2019 20:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UXNILKLAImY+O3C/yY4NZNxvq1cHccsQVXJ2BJTQgOM=; b=apVXB1PWMvsaPyIO9h6pS1Nhvp9Q2JIiouLzfs3soCg/zuZmera2Ga+Icao8sFFnEz EBIz842pqrLlk/N9Eql58X+9M4Z1KmPE0pslUDKEN8htrZykpk93hPsho0KraxgOvRfD 1/IVil3CQuudJbIyeh59kx9JI6ou22wS9jwlP/6vR6Ah2lteBFGHRShaaaV5NfUEFn+R r6VRLjMp9j2qLW8USvj1YB1NmxTJJTIm1BfcqMLhQAyk4qQL8aKCAg1FwLRBQc8xVSqe EPmsqXIJWz9wD7jmp6vvcemTYf2rF66vO/NWfdgSVvRs7O5cJMCVFwCVA0ioW91s6Xqv azvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UXNILKLAImY+O3C/yY4NZNxvq1cHccsQVXJ2BJTQgOM=; b=d5ADpW/1l0llT8gMIb/A/g2EEiFaJ7//4fECkP0AMTsOUBH/yI3BextfjyH5blQgwK smYMQ1ioHDI/JCQzk+1/wF7vA3kagsf6ptFn4LfE9eC0wY/UNn7I1UaMKMlQbERaNAjG GokWNrWTSLZaLg76nBK393jSzndjEYn5mIQJPL+RbsaAmGDes1Y/F4DtJvL5snyvt6kP dKL6S38hC/19cBKEQUnq1BLTHoPhtlVc8E/GPRIQjXGQHTiEeUNFG8fo1nDrrX+NV+Xt j8GZG9wntbBZw0+jPONnOqKgQ5OUTwncxMz+xpJ2XGRsj/N7le+epYkPaBEVQiQH7as9 uwAw== X-Gm-Message-State: APjAAAW9HMe7k9NHm/zodTlxwepBk627tcGm048KHAgoLjO/rIrGhVOX dcC87xIW6ehCSHzkIeCK0dFr828f5kY= X-Google-Smtp-Source: APXvYqzpN8+L4EvSFtKICuynGRLtKyIvW9zUHtVwtSDWH2+34eOBM8q0QPmsCq2C/+uR0l32vPCR5g== X-Received: by 2002:a62:1690:: with SMTP id 138mr36461290pfw.28.1556164014387; Wed, 24 Apr 2019 20:46:54 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id p9sm30897911pfi.186.2019.04.24.20.46.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 20:46:53 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: SVN r346645 breaks build of DRM drivers From: Enji Cooper In-Reply-To: <0f965585-9d30-6ce8-035e-3453b1c9e95c@protected-networks.net> Date: Wed, 24 Apr 2019 20:46:52 -0700 Cc: FreeBSD Current , Tycho Nightingale Content-Transfer-Encoding: quoted-printable Message-Id: References: <0f965585-9d30-6ce8-035e-3453b1c9e95c@protected-networks.net> To: Michael Butler X-Mailer: Apple Mail (2.3445.104.8) X-Rspamd-Queue-Id: 77CF58E116 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.934,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2019 03:46:57 -0000 (Fixing CC) > On Apr 24, 2019, at 8:03 PM, Michael Butler = wrote: >=20 > The removal of dma_mask (around line 105) in > /usr/src/sys/compat/linuxkpi/common/include/linux/device.h breaks the > DRM loadable modules :-( >=20 > As follows .. >=20 > --- amdgpu_amdkfd.o --- > = /usr/ports/graphics/drm-current-kmod/work/kms-drm-068d6be/drivers/gpu/drm/= amd/amdgpu/amdgpu_amdkfd.c:284:37: > error: no member named 'dma_mask' in 'struct device' > uint64_t address_mask =3D adev->dev->dma_mask ? > ~*adev->dev->dma_mask : > ~~~~~~~~~ ^ > = /usr/ports/graphics/drm-current-kmod/work/kms-drm-068d6be/drivers/gpu/drm/= amd/amdgpu/amdgpu_amdkfd.c:284:61: > error: no member named 'dma_mask' in 'struct device' > uint64_t address_mask =3D adev->dev->dma_mask ? > ~*adev->dev->dma_mask : > ~~~~~~~~~ ^ > 2 errors generated.