From owner-svn-src-all@freebsd.org Tue Aug 4 08:30:25 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E43C9B2C0B for ; Tue, 4 Aug 2015 08:30:25 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 06B661170 for ; Tue, 4 Aug 2015 08:30:24 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wicgj17 with SMTP id gj17so139140110wic.1 for ; Tue, 04 Aug 2015 01:30:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=+PcW0Iy0BnbRfJen3gQ5XYZzBmhJB3SbnkUExrRw5BA=; b=cREnS/v1RgKm+Twr+GbIp3jj6cWschx1hZyfll42NXE7zinGlyBAqgWc+0IaPNkkEi QFs8AAcYGqDPEMqDl02zpwHNTkorhRlRe+lV4NHxLVBW5cacxDwJRhTBOlNBoyFW2fR8 a2iSRdnCI+wDg4LH4YdVwF8iBAm4XnOERIVdZ/YB9KMYdbHmJ3nEARyA4bKYMw7Cl5cK aohmcRT56KrmRoFwor12ytJqsQ7twUqIIaVJvqzjpvKNgp2DI6mZ5gFZXPv5fErzuU5J Erodp3QBoK1rwrfwsC0ZI9y3EZNoIFGnOl/Qic60rl6nBV+NCmKmbJlIvv/nM40i9E/R D4gA== X-Gm-Message-State: ALoCoQmySI/9/oeimw5xQO4Fc0jQGzSm3gH3hOBL5zwdqjF9YLXtl2x/nGcMglU+lxaB0e7GMgeX X-Received: by 10.194.192.72 with SMTP id he8mr5514042wjc.11.1438677022811; Tue, 04 Aug 2015 01:30:22 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id wx9sm574444wjb.6.2015.08.04.01.30.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2015 01:30:21 -0700 (PDT) Subject: Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Warner Losh , Slawa Olhovchenkov References: <201508030934.t739YAkT026668@repo.freebsd.org> <20150803094730.GA24698@zxy.spb.ru> <55BF431E.3020601@freebsd.org> <2757800.HIDNx1G49O@overcee.wemm.org> <20150803111942.GB2072@kib.kiev.ua> <55BF557B.60009@multiplay.co.uk> <20150803120359.GC2072@kib.kiev.ua> <55BFC296.5050402@freebsd.org> <20150803194412.GC8792@zxy.spb.ru> Cc: Julian Elischer , Konstantin Belousov , Peter Wemm , svn-src-all@freebsd.org, svn-src-head@freebsd.org, src-committers@freebsd.org From: Steven Hartland Message-ID: <55C07826.9070002@multiplay.co.uk> Date: Tue, 4 Aug 2015 09:30:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 08:30:25 -0000 On 03/08/2015 21:48, Warner Losh wrote: >> On Aug 3, 2015, at 1:44 PM, Slawa Olhovchenkov wrote: >> >> On Tue, Aug 04, 2015 at 03:35:50AM +0800, Julian Elischer wrote: >> >>> On 8/3/15 8:03 PM, Konstantin Belousov wrote: >>>> On Mon, Aug 03, 2015 at 12:50:19PM +0100, Steven Hartland wrote: >>>>> For this change I don't want to get into fixing the thread0 stack size, >>>>> which can be done later, just >>>>> to provide a reasonable warning to the user that smaller values could >>>>> cause a panic. >>>> Hmm, is it limited to the thread0 only ? I.e., would only increasing >>>> the initial thread stack size be enough to boot the kernel ? The zfs >>>> threads do request larger stack size, I know this. >>>> >>>> Can somebody test the following patch in the i386 configuration which >>>> does not boot ? >>> I think this is a reasonable thing to do. Thread0 (and proc0) are special. >>> I don't see why giving it a specially sized stack would be a problem. >> This is always do for ARM. >> May be need increase stack size for Thread0 on ARM too? > Seems reasonable. There should be a MI way of doing this, but all the code and defines are buried in MD files, so each architecture needs some love to make this a reality. > > Warner In the mean time are people happier with https://reviews.freebsd.org/D3279 or should I just leave it using the #define until someone has time to work on a full solution? Regards Steve