From nobody Fri May 1 09:10:15 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g6QHD409Kz6cDm9; Fri, 01 May 2026 09:10:16 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g6QHD2w98z3sjg; Fri, 01 May 2026 09:10:16 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777626616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h9/Lwg3+8NY0zyLki0DfURUeaBYwYJUA1NaXg3jmGMo=; b=hAbtmiFJmcIW+JcnCUPILM09h2uBAd9sivh5Qlscw51DIoM+HUfOY3Ge28ZV5QcbJyJ0Bd 3ZopBTniGGud458MSryk8xCBZWYjeJ3xdILKdQ8yfYaMNSqPYP3U23dU2+5CVrTj8p+Gms Y1uGIyf2i0XjJmMWLAtJMBrTjPlX3mMKiHCj4q6XtTT3hnzUXc0kwnLsa7wPXkevJh+Sxa 0ZpGitfeL1DzCG4Zo3ZdJ+JPHegOZEePIfyMsFNnbKA0ZuJuTxF/rQRWpOVtJkVSKeVrnT bNASxIl4HqlDsl317rlvQoyNyrTYwHNRzFdFwLk9nElja6HhtedMKoCZlgEWRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777626616; a=rsa-sha256; cv=none; b=cuk2hw6qIHNM3paNGWcu/g7ODspqh2DbF6+EJrIsgtBg0njsXw9q2L78zgCS23n1gwHOOx VLaFdfNp1bJcNksZeFFD4nyXYstRInF3hL7s2L70EueY6653kdvAjOYGwEA01wdg9iGqm4 GCKRSejnkAfRzAf2kyTlRqMLY5eiOAqQ712Fn5UmwEcjiwHFFwrgozoYC4z7g9TpGgZuC+ enleivZODhTJx9P62NyaTwvcKIx2TkGSqhkQ5bxBN2/1eqov+ZkDOMTX+On/Pom5/YzjgH kHLDe11DbkDY5wm9TP6Ksv8u0mil4BT3RsoDfjSC4CnTQ8rpCIVd6cFOolgGIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777626616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h9/Lwg3+8NY0zyLki0DfURUeaBYwYJUA1NaXg3jmGMo=; b=l4yO57gyeGODn4IK4Ufb60+GDqpGiq09PAnRo54ak8IpSv52lu5rtQBUnVK5I37RruEebx 5Z7yasRFlY6/SIn6vetO5zLi3AbVNbCJYcR/+oK++fkndvW8tnLu1TV5vzxQqCWxagEqyN AN17KUoqkZe87NFkeCNWoUIOnznvm/MvvrU6MNv7m0v35YGBu6blj4rKP2N7H9kKL3QqWp R1EAcjZogWhw0lybSyVeTxnXLIIx2uLmR7cgff+WfIZFgFSCA1wqAETTXunDGS9lHJkUpk sT4bWmR2skkXR6/87rKpDaVfV6qcXDO7CLRIwvQquONkVoS9uGF1sRu9uG7w+w== Received: from [192.168.1.231] (217-209-194-237-no600.tbcn.telia.com [217.209.194.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: diizzy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g6QHC5j2Yz17pB; Fri, 01 May 2026 09:10:15 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------dKcilPThqtYwMNFPCYPJL3me" Message-ID: <3b96bcca-8a2f-4ee4-b4f9-0caf445a73ab@FreeBSD.org> Date: Fri, 1 May 2026 11:10:15 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: git: e70dc4653b10 - main - devel/vectorscan: Add vectorscan 5.4.12 From: Daniel Engberg To: Xin LI , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <69f462a6.3e5bc.7d4f833e@gitrepo.freebsd.org> <05b140a6-099f-4687-bc4c-0168182e0d79@FreeBSD.org> Content-Language: en-US In-Reply-To: <05b140a6-099f-4687-bc4c-0168182e0d79@FreeBSD.org> This is a multi-part message in MIME format. --------------dKcilPThqtYwMNFPCYPJL3me Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-05-01 11:04, Daniel Engberg wrote: > On 2026-05-01 10:21, Xin LI wrote: >> The branch main has been updated by delphij: >> >> URL:https://cgit.FreeBSD.org/ports/commit/?id=e70dc4653b10f5ea53da0a2b6ed286fe61555e22 >> >> commit e70dc4653b10f5ea53da0a2b6ed286fe61555e22 >> Author: Xin LI >> AuthorDate: 2025-10-30 05:25:07 +0000 >> Commit: Xin LI >> CommitDate: 2026-05-01 08:20:55 +0000 >> >> devel/vectorscan: Add vectorscan 5.4.12 >> >> Portable fork of high-performance multiple regex matching library >> --- >> devel/Makefile | 1 + >> devel/vectorscan/Makefile | 66 ++++++++++++++++++++++ >> devel/vectorscan/distinfo | 5 ++ >> .../vectorscan/files/patch-cmake_build__wrapper.sh | 27 +++++++++ >> devel/vectorscan/pkg-descr | 12 ++++ >> devel/vectorscan/pkg-plist | 14 +++++ >> 6 files changed, 125 insertions(+) >> >> diff --git a/devel/Makefile b/devel/Makefile >> index 1b3717183446..aeda92049c62 100644 >> --- a/devel/Makefile >> +++ b/devel/Makefile >> @@ -8698,6 +8698,7 @@ >> SUBDIR += vc-intrinsics >> SUBDIR += vcglib >> SUBDIR += vdf >> + SUBDIR += vectorscan >> SUBDIR += venom >> SUBDIR += vera++ >> SUBDIR += vexcl >> diff --git a/devel/vectorscan/Makefile b/devel/vectorscan/Makefile >> new file mode 100644 >> index 000000000000..dd8bc0cea64d >> --- /dev/null > Hi, > > Please use DISTVERSION instead of PORTVERSION > https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions > Please fix ordering, See Example 7 CMAKE_ARGS and CFLAGS are also > oddly placed, portfmt will help to improve port layout but it does > have some odd suggestions at times. Port doesn't respect CFLAGS (-O3 > and CPUTYPE) > https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags > https://codeberg.org/gentoo/gentoo/src/branch/master/dev-libs/vectorscan/vectorscan-5.4.12.ebuild > might be useful Do not set flags such as NATIVE, it breaks on no x86 > arches and port should rely on CPUTYPE as mentioned in PR > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294399 and we've > been actively migrating away from that. > > Preferably we should unbundle boost > https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices > > For consistency with the rest of the tree there should be a toggle for > static library not shared, > https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n480 > > Best regards, Daniel > Hi, Hit enter too soon, port also uses -std=c++17 while Makefile sets USES= compiler:c++11-lib Best regards, Daniel --------------dKcilPThqtYwMNFPCYPJL3me Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 2026-05-01 11:04, Daniel Engberg wrote:
On 2026-05-01 10:21, Xin LI wrote:
The branch main has been updated by delphij:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e70dc4653b10f5ea53da0a2b6ed286fe61555e22

commit e70dc4653b10f5ea53da0a2b6ed286fe61555e22
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2025-10-30 05:25:07 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2026-05-01 08:20:55 +0000

    devel/vectorscan: Add vectorscan 5.4.12
    
    Portable fork of high-performance multiple regex matching library
---
 devel/Makefile                                     |  1 +
 devel/vectorscan/Makefile                          | 66 ++++++++++++++++++++++
 devel/vectorscan/distinfo                          |  5 ++
 .../vectorscan/files/patch-cmake_build__wrapper.sh | 27 +++++++++
 devel/vectorscan/pkg-descr                         | 12 ++++
 devel/vectorscan/pkg-plist                         | 14 +++++
 6 files changed, 125 insertions(+)

diff --git a/devel/Makefile b/devel/Makefile
index 1b3717183446..aeda92049c62 100644
--- a/devel/Makefile
+++ b/devel/Makefile
@@ -8698,6 +8698,7 @@
     SUBDIR += vc-intrinsics
     SUBDIR += vcglib
     SUBDIR += vdf
+    SUBDIR += vectorscan
     SUBDIR += venom
     SUBDIR += vera++
     SUBDIR += vexcl
diff --git a/devel/vectorscan/Makefile b/devel/vectorscan/Makefile
new file mode 100644
index 000000000000..dd8bc0cea64d
--- /dev/null
Hi,

Please use DISTVERSION instead of PORTVERSION https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-versions Please fix ordering, See Example 7 CMAKE_ARGS and CFLAGS are also oddly placed, portfmt will help to improve port layout but it does have some odd suggestions at times. Port doesn't respect CFLAGS (-O3 and CPUTYPE) https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags https://codeberg.org/gentoo/gentoo/src/branch/master/dev-libs/vectorscan/vectorscan-5.4.12.ebuild might be useful Do not set flags such as NATIVE, it breaks on no x86 arches and port should rely on CPUTYPE as mentioned in PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=294399 and we've been actively migrating away from that.

Preferably we should unbundle boost
https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs-practices

For consistency with the rest of the tree there should be a toggle for static library not shared,
https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n480

Best regards, Daniel

Hi,

Hit enter too soon, port also uses -std=c++17 while Makefile sets USES= compiler:c++11-lib

Best regards,
Daniel --------------dKcilPThqtYwMNFPCYPJL3me--