From owner-freebsd-threads@freebsd.org Thu Sep 24 19:11:31 2015 Return-Path: Delivered-To: freebsd-threads@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CCDC6A088F7 for ; Thu, 24 Sep 2015 19:11:31 +0000 (UTC) (envelope-from schulz.j@gmail.com) Received: from mail-pa0-x22d.google.com (mail-pa0-x22d.google.com [IPv6:2607:f8b0:400e:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F1CF1B9C for ; Thu, 24 Sep 2015 19:11:31 +0000 (UTC) (envelope-from schulz.j@gmail.com) Received: by pacex6 with SMTP id ex6so80891247pac.0 for ; Thu, 24 Sep 2015 12:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Ms5H+5Z29G/S1ulGA62nuaLtbKCr+QMqgvUtKk07Z2A=; b=gwThkmwgtPUNC4SllKEYG+CSj+EXeU3Kesvn+QbZ2OzH0X5G6PxhiroElIEjXDnwPr /1sbUAHdYhMFti4vts+FcyYU5byAmAWGJZD1S8ZbjcVTn/sSjl34IEIfvjX5x4LqYcXH d0V+M01PbkCYtGHdlK1VYs5IQz540n+7XnNjLsl7b8Iqgq/BsAi2fsbSEXadWrXpNBhs SvYAlKEWHLHhXPOXRsyo95cgQM/G14Ckm60zrzHsM92wQZdrVt5WiVWNDSlNijJ77f0i D+5qTyfD9LecWydoCX0W53rmYooX6I2vSb1WgPo8Cj7Yl1BsQ2v2SpLm04REI4nNDawN Rogw== X-Received: by 10.66.236.10 with SMTP id uq10mr1532696pac.55.1443121891314; Thu, 24 Sep 2015 12:11:31 -0700 (PDT) Received: from gmail.com (c-73-140-192-75.hsd1.wa.comcast.net. [73.140.192.75]) by smtp.gmail.com with ESMTPSA id xd10sm15046631pab.25.2015.09.24.12.11.29 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Sep 2015 12:11:30 -0700 (PDT) Sender: Jason Schulz Date: Thu, 24 Sep 2015 12:11:21 -0700 From: Jason Schulz To: Konstantin Belousov Cc: freebsd-threads@freebsd.org Subject: Re: pthread_getaffinity_np issue Message-ID: <20150924191121.GG3104@gmail.com> References: <20150924181127.GC3104@gmail.com> <20150924183246.GK67105@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150924183246.GK67105@kib.kiev.ua> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 19:11:31 -0000 Hey Konstantin, Thanks for the quick response. The version I'm developing with is the latest release. [jason@fb ~/development/git/uxcn/yafd]$ uname -a FreeBSD fb 10.2-RELEASE FreeBSD 10.2-RELEASE #0 r286666: Wed Aug 12 15:26:37 UTC 2015 root@releng1.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 I was able to narrow it down to the following, #include #include #include int main(int argc, char* argv[argc]) { long cs = 0; pthread_t this = pthread_self(); cpuset_t cpus; CPU_ZERO(&cpus); int err = pthread_getaffinity_np(this, sizeof(cpus), &cpus); if (err) return err; cs = (long) CPU_COUNT(&cpus); printf("num cpus... %li\n", cs); return 0; } Compiling with '-D_XOPEN_SOURCE=700', [jason@fb /tmp]$ clang -D_XOPEN_SOURCE=700 -pthread -o num_cpus num_cpus.c num_cpus.c:21:15: warning: implicit declaration of function '__bitcountl' is invalid in C99 [-Wimplicit-function-declaration] cs = (long) CPU_COUNT(&cpus); ^ /usr/include/sys/cpuset.h:63:24: note: expanded from macro 'CPU_COUNT' #define CPU_COUNT(p) BIT_COUNT(CPU_SETSIZE, p) ^ /usr/include/sys/bitset.h:185:14: note: expanded from macro 'BIT_COUNT' __count += __bitcountl((p)->__bits[__i]); \ ^ 1 warning generated. /tmp/num_cpus-560a33.o: In function `main': num_cpus.c:(.text+0xbd): undefined reference to `__bitcountl' clang: error: linker command failed with exit code 1 (use -v to see invocation) However compiling without '-D_XOPEN_SOURCE=700' works, [jason@fb /tmp]$ clang -pthread -o num_cpus num_cpus.c [jason@fb /tmp]$ Should I file a bug report? -J On Thu, Sep 24, 2015 at 09:32:46PM +0300, Konstantin Belousov wrote: > On Thu, Sep 24, 2015 at 11:11:27AM -0700, Jason Schulz wrote: > > I'm having an issue using the non-posix thread affinity methods. Specifically, I'm having trouble using CPU_COUNT. I'm trying to use the following code to get the current number of processors in a processes affinity... > > > > > > > > long cs = 0; > > > > #if defined(HAVE_LINUX) || defined(HAVE_FREEBSD) > > > > pthread_t this = pthread_self(); > > > > cpu_set_t cpus; > > > > CPU_ZERO(&cpus); > > > > int err = pthread_getaffinity_np(this, sizeof(cpus), &cpus); > > > > if (err) > > return err; > > > > cs = (long) CPU_COUNT(&cpus); > > > > > > > > However, I get the compiler error... > > > > > > > > clang -DHAVE_CONFIG_H -I. -g -O2 -D_THREAD_SAFE -pthread -pipe -std=c99 -D_XOPEN_SOURCE=700 -pedantic -Wall -Wextra -Wsign-conversion -Wconversion -Werror -MT thread.o -MD -MP -MF .deps/thread.Tpo -c -o thread.o thread.c > > thread.c:85:15: error: implicit declaration of function '__bitcountl' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > > cs = (long) CPU_COUNT(&cpus); > > ^ > > /usr/include/sys/cpuset.h:63:24: note: expanded from macro 'CPU_COUNT' > > #define CPU_COUNT(p) BIT_COUNT(CPU_SETSIZE, p) > > ^ > > /usr/include/sys/bitset.h:185:14: note: expanded from macro 'BIT_COUNT' > > __count += __bitcountl((p)->__bits[__i]); \ > > ^ > > 1 error generated. > > > > > > > > I'm able to use CPU_ISSET to the same effect, but obviously I'd rather use CPU_COUNT. Suggestions? > > > > Show the minimal example demonstrating the issue, specify the version > of the system and which you use. My guess is that you did not added > #include before including sys/cpuset.h.